From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752227AbcAFRFw (ORCPT ); Wed, 6 Jan 2016 12:05:52 -0500 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:57885 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752066AbcAFRFu (ORCPT ); Wed, 6 Jan 2016 12:05:50 -0500 Message-ID: <1452099937.2768.123.camel@decadent.org.uk> Subject: Re: [PATCH 4.2.y-ckt 009/211] xhci: don't finish a TD if we get a short transfer event mid TD From: Ben Hutchings To: Kamal Mostafa , linux-kernel@vger.kernel.org, stable@vger.kernel.org, kernel-team@lists.ubuntu.com Cc: Mathias Nyman , Greg Kroah-Hartman Date: Wed, 06 Jan 2016 17:05:37 +0000 In-Reply-To: <1452023119-25647-10-git-send-email-kamal@canonical.com> References: <1452023119-25647-1-git-send-email-kamal@canonical.com> <1452023119-25647-10-git-send-email-kamal@canonical.com> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-fMpxPw2kNHILnMgyqved" X-Mailer: Evolution 3.18.2-1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 192.168.4.247 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-fMpxPw2kNHILnMgyqved Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2016-01-05 at 11:41 -0800, Kamal Mostafa wrote: > 4.2.8-ckt1 -stable review patch.=C2=A0=C2=A0If anyone has any objections,= please let me know. >=20 > ------------------ >=20 > From: Mathias Nyman >=20 > commit e210c422b6fdd2dc123bedc588f399aefd8bf9de upstream. >=20 > If the difference is big enough between the bytes asked and received > in a bulk transfer we can get a short transfer event pointing to a TRB in > the middle of the TD. We don't want to handle the TD yet as we will anywa= y > receive a new event for the last TRB in the TD. >=20 > Hold off from finishing the TD and removing it from the list until we > receive an event for the last TRB in the TD >=20 > Signed-off-by: Mathias Nyman > Signed-off-by: Greg Kroah-Hartman > [ kamal: backport to 4.2-stable: context ] > Signed-off-by: Kamal Mostafa [...] This causes regressions (see https://bugs.debian.org/808602=C2=A0and https://bugs.debian.org/808953 ) so please hold off until there's a complete fix upstream. Ben. --=20 Ben Hutchings It is easier to write an incorrect program than to understand a correct one= . --=-fMpxPw2kNHILnMgyqved Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIVAwUAVo1JYee/yOyVhhEJAQrWHA//cg8GMGpdjZlFIeWjOJrBKjBbIJJzVVKU tThjbvPoHx/RTPrTq1LIpARPSceE2oWNfggwjEEdtW8FgdKXM/nT38/WxD0xPKRP 8pxp397BTjIj0AtJN9p5IvBK3aNgykkK6FC9Uct+YX6pzDU5Ult1TQflD/ufc1mp kqZzdIxCI10mFepm0UqGmTrIwWH5gvSllrKjzh6Z4VFhr096SQYoUOSCYiCpngeU v9q5pPNjRj+QHmlcB+1tiXxkxbME8HgRUZQOwdUqBBZCIoMuqQZL7iQiCFdlh+O2 8NV9ZLjdXvYrY+KoNAe+DYe0gFktCuWhX6E19Fr98H/z1nfCll0rTppV1FT5knGr Bf4aDM2eq+XRFNsMOd5ZxnAoH9rjuePCswcQi7e54TcTusM6/lcTMHko0yXwWD0L e8v9OuYYuBO9vPqy1Xpyx/4tSf/0ItAuFfvY+1XHQ/9GLUUcukG0iVyvmaVGbjcq Mq1SRLqwwaEoC4xC3DpoOPJacrK0FcO9B40zR22LhOfLbrAaDBOir2wtvC125LyR FDy83Z0nOnrlfNlCEVfxeO+VvdoMMpzgQ3dzK93MMdmDtYinOvFhnup3sz6jSqb9 fPGUn9D2db3q9fnEQiU6/cboov+AhO2D+1QtOOgh+YMY1ExchZqEilUpQHhK0hUS a1Zd3AaYGd8= =D5YE -----END PGP SIGNATURE----- --=-fMpxPw2kNHILnMgyqved--