From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752528AbcAFTzP (ORCPT ); Wed, 6 Jan 2016 14:55:15 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:59506 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752493AbcAFTzI (ORCPT ); Wed, 6 Jan 2016 14:55:08 -0500 Message-ID: <1452110100.4431.18.camel@fourier> Subject: Re: [PATCH 4.2.y-ckt 009/211] xhci: don't finish a TD if we get a short transfer event mid TD From: Kamal Mostafa To: Ben Hutchings , Luis Henriques Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, kernel-team@lists.ubuntu.com, Mathias Nyman , Greg Kroah-Hartman Date: Wed, 06 Jan 2016 11:55:00 -0800 In-Reply-To: <1452099937.2768.123.camel@decadent.org.uk> References: <1452023119-25647-1-git-send-email-kamal@canonical.com> <1452023119-25647-10-git-send-email-kamal@canonical.com> <1452099937.2768.123.camel@decadent.org.uk> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2016-01-06 at 17:05 +0000, Ben Hutchings wrote: > On Tue, 2016-01-05 at 11:41 -0800, Kamal Mostafa wrote: > > 4.2.8-ckt1 -stable review patch. If anyone has any objections, please let me know. > > > > ------------------ > > > > From: Mathias Nyman > > > > commit e210c422b6fdd2dc123bedc588f399aefd8bf9de upstream. > > > > If the difference is big enough between the bytes asked and received > > in a bulk transfer we can get a short transfer event pointing to a TRB in > > the middle of the TD. We don't want to handle the TD yet as we will anyway > > receive a new event for the last TRB in the TD. > > > > Hold off from finishing the TD and removing it from the list until we > > receive an event for the last TRB in the TD > > > > Signed-off-by: Mathias Nyman > > Signed-off-by: Greg Kroah-Hartman > > [ kamal: backport to 4.2-stable: context ] > > Signed-off-by: Kamal Mostafa > [...] > > This causes regressions (see https://bugs.debian.org/808602 and > https://bugs.debian.org/808953 ) so please hold off until there's a > complete fix upstream. Thanks for the heads-up, Ben. I'll defer it for 4.2-stable. I'm thinking that it should also be reverted from the stable kernels that already carry it (3.2, 3.13, 3.16, 3.19), unless that complete upstream fix is really imminent. Is it? -Kamal