From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Jiri Olsa <jolsa@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Andi Kleen <andi@firstfloor.org>, Wang Nan <wangnan0@huawei.com>
Subject: [PATCH v4 1/5] perf tools: Fix sorting of dynamic sort keys
Date: Thu, 7 Jan 2016 09:12:25 +0900 [thread overview]
Message-ID: <1452125549-1511-1-git-send-email-namhyung@kernel.org> (raw)
Currently it sorts entries in reverse (alphabetic) order, fix it.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
This patch can be folded into the original patch c7c2a5e40f17
("perf tools: Add dynamic sort key for tracepoint events")
tools/perf/util/sort.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
index 04e2a5cb19e3..425097d2a1cd 100644
--- a/tools/perf/util/sort.c
+++ b/tools/perf/util/sort.c
@@ -1795,7 +1795,7 @@ static int64_t __sort__hde_cmp(struct perf_hpp_fmt *fmt,
update_dynamic_len(hde, b);
}
- return memcmp(a->raw_data + offset, b->raw_data + offset, size);
+ return memcmp(b->raw_data + offset, a->raw_data + offset, size);
}
bool perf_hpp__is_dynamic_entry(struct perf_hpp_fmt *fmt)
--
2.6.4
next reply other threads:[~2016-01-07 0:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 0:12 Namhyung Kim [this message]
2016-01-07 0:12 ` [PATCH v4 2/5] perf tools: Separate hpp->sort callback for dynamic sort keys Namhyung Kim
2016-01-07 0:12 ` [PATCH v4 3/5] perf tools: Fix dynamic sort keys to sort properly Namhyung Kim
2016-01-07 0:12 ` [PATCH v4 4/5] perf tools: Support dynamic sort keys for -F/--fields Namhyung Kim
2016-01-07 9:24 ` Jiri Olsa
2016-01-07 10:54 ` Namhyung Kim
2016-01-07 0:12 ` [PATCH v4 5/5] perf evlist: Add --trace-fields option to show trace fields Namhyung Kim
2016-01-08 17:22 ` Arnaldo Carvalho de Melo
2016-01-09 16:42 ` [tip:perf/core] " tip-bot for Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452125549-1511-1-git-send-email-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=andi@firstfloor.org \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox