From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752817AbcAGCwN (ORCPT ); Wed, 6 Jan 2016 21:52:13 -0500 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:60013 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752254AbcAGCwK (ORCPT ); Wed, 6 Jan 2016 21:52:10 -0500 Message-ID: <1452135122.2768.159.camel@decadent.org.uk> Subject: Re: [PATCH 4.2.y-ckt 009/211] xhci: don't finish a TD if we get a short transfer event mid TD From: Ben Hutchings To: Kamal Mostafa , Luis Henriques Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, kernel-team@lists.ubuntu.com, Mathias Nyman , Greg Kroah-Hartman Date: Thu, 07 Jan 2016 02:52:02 +0000 In-Reply-To: <1452110100.4431.18.camel@fourier> References: <1452023119-25647-1-git-send-email-kamal@canonical.com> <1452023119-25647-10-git-send-email-kamal@canonical.com> <1452099937.2768.123.camel@decadent.org.uk> <1452110100.4431.18.camel@fourier> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-jZ7AJD6sdL2uzfeMHfmu" X-Mailer: Evolution 3.18.2-1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 192.168.4.247 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-jZ7AJD6sdL2uzfeMHfmu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2016-01-06 at 11:55 -0800, Kamal Mostafa wrote: > On Wed, 2016-01-06 at 17:05 +0000, Ben Hutchings wrote: > > On Tue, 2016-01-05 at 11:41 -0800, Kamal Mostafa wrote: > > > 4.2.8-ckt1 -stable review patch.=C2=A0=C2=A0If anyone has any objecti= ons, please let me know. > > >=20 > > > ------------------ > > >=20 > > > From: Mathias Nyman > > >=20 > > > commit e210c422b6fdd2dc123bedc588f399aefd8bf9de upstream. > > >=20 > > > If the difference is big enough between the bytes asked and received > > > in a bulk transfer we can get a short transfer event pointing to a TR= B in > > > the middle of the TD. We don't want to handle the TD yet as we will a= nyway > > > receive a new event for the last TRB in the TD. > > >=20 > > > Hold off from finishing the TD and removing it from the list until we > > > receive an event for the last TRB in the TD > > >=20 > > > Signed-off-by: Mathias Nyman > > > Signed-off-by: Greg Kroah-Hartman > > > [ kamal: backport to 4.2-stable: context ] > > > Signed-off-by: Kamal Mostafa > > [...] > >=20 > > This causes regressions (see https://bugs.debian.org/808602 and > > https://bugs.debian.org/808953 ) so please hold off until there's a > > complete fix upstream. >=20 > Thanks for the heads-up, Ben.=C2=A0=C2=A0I'll defer it for 4.2-stable. >=20 > I'm thinking that it should also be reverted from the stable kernels > that already carry it (3.2, 3.13, 3.16, 3.19), unless that complete > upstream fix is really imminent.=C2=A0=C2=A0Is it? Normally if there's a regression that affects both mainline and stable branches, we wait for it to be fixed in mainline first. Ben. --=20 Ben Hutchings Life would be so much easier if we could look at the source code. --=-jZ7AJD6sdL2uzfeMHfmu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIVAwUAVo3S0ue/yOyVhhEJAQqB0xAAo/2aO0NHZCKkoG2AVSvs667QgRa/oc+P d/maCMsZSXSr9tlW1tm0ApFyz6pzLV0wW9vbBTazCd8IqKWSVnOK9XoihYAzzULD Pni1tRXOpGUhcjmsQyxnvA44mfH+TIxKoJv5EQSVJZe1WYV4KTnDGPldN4o+bxeH +5U2pXwQF1sudo0Lv+KGDV126ZmgSi5+rYe56TD7qUiLym5iOu/gXeWdxJjBph1o 4pS2eAQT5+08ENiq6EPCzE1hJ+Ol++1FcFuxIVP4uSjycqCLLw9WnXrjH2lhe1oU ImPwLyXQRZYl3QhEzyPAJppfLtAzMiQAcR4GLVWTcTr9TSN25nOW3KRh93Rz+MpM JG9HigZVSo8JRygwIFy9uL5GL7kM6HMCHpe6y5oi6D4AjqzVm7jt5zvOQv0NzRzj q6ZI/QRiXUy1WV8XoPE+DmfO2d7FKdaW0CsJLXzyTZF4RKFvIsWr0+eSsJK6NfWD c+2MrGMXdsCBvYgo5KEBqYEnS0x42bEKyt7IGGIRW9DG7d16dvDaSHyTMfnXV20I nPeOn6cWUJ5QJ6wDJL4qLRTl8zMwnFCXoaVdU1AP9wn0Xnj/S3PxdNuo5eO2bNnp /LI18hb3Lcvhgs2RvVH6djwCe/T/5SHVRa3eQnU7C0T/bC+JVg1M7AvLrPVApRZK bw6svCBDJOg= =hNTB -----END PGP SIGNATURE----- --=-jZ7AJD6sdL2uzfeMHfmu--