From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753339AbcAGPAa (ORCPT ); Thu, 7 Jan 2016 10:00:30 -0500 Received: from mail-pa0-f46.google.com ([209.85.220.46]:35669 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752241AbcAGPA1 (ORCPT ); Thu, 7 Jan 2016 10:00:27 -0500 From: tim.gardner@canonical.com To: x86@kernel.org, linux-kernel@vger.kernel.org Cc: Tim Gardner , Borislav Petkov , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" Subject: [PATCH v4.4-rc8 1/4] x86/microcode/intel: save_mc_for_early: Squelch frame size warning Date: Thu, 7 Jan 2016 07:59:56 -0700 Message-Id: <1452178799-20878-2-git-send-email-tim.gardner@canonical.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1452178799-20878-1-git-send-email-tim.gardner@canonical.com> References: <1452178799-20878-1-git-send-email-tim.gardner@canonical.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tim Gardner arch/x86/kernel/cpu/microcode/intel.c: In function 'save_mc_for_early': arch/x86/kernel/cpu/microcode/intel.c:516:1: warning: the frame size of 1032 bytes is larger than 1024 bytes [-Wframe-larger-than=] gcc version 5.3.1 20160101 (Ubuntu 5.3.1-5ubuntu1) Cc: Borislav Petkov Cc: Thomas Gleixner Cc: Ingo Molnar Cc: "H. Peter Anvin" Signed-off-by: Tim Gardner --- arch/x86/kernel/cpu/microcode/intel.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/arch/x86/kernel/cpu/microcode/intel.c b/arch/x86/kernel/cpu/microcode/intel.c index ce47402..bee5e84 100644 --- a/arch/x86/kernel/cpu/microcode/intel.c +++ b/arch/x86/kernel/cpu/microcode/intel.c @@ -463,13 +463,18 @@ static DEFINE_MUTEX(x86_cpu_microcode_mutex); */ int save_mc_for_early(u8 *mc) { - struct microcode_intel *mc_saved_tmp[MAX_UCODE_COUNT]; + struct microcode_intel **mc_saved_tmp; unsigned int mc_saved_count_init; unsigned int mc_saved_count; struct microcode_intel **mc_saved; int ret = 0; int i; + mc_saved_tmp = kcalloc(MAX_UCODE_COUNT, sizeof(*mc_saved_tmp), + GFP_KERNEL); + if (!mc_saved_tmp) + return -ENOMEM; + /* * Hold hotplug lock so mc_saved_data is not accessed by a CPU in * hotplug. @@ -512,6 +517,7 @@ int save_mc_for_early(u8 *mc) out: mutex_unlock(&x86_cpu_microcode_mutex); + kfree(mc_saved_tmp); return ret; } EXPORT_SYMBOL_GPL(save_mc_for_early); -- 1.9.1