From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752320AbcAGQ4p (ORCPT ); Thu, 7 Jan 2016 11:56:45 -0500 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:42849 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751534AbcAGQ4n convert rfc822-to-8bit (ORCPT ); Thu, 7 Jan 2016 11:56:43 -0500 Message-ID: <1452185798.2915.44.camel@pengutronix.de> Subject: Re: [RFC v2 2/4] dt-bindings: i2c: mux: demux-pinctrl: add bindings From: Jan =?ISO-8859-1?Q?L=FCbbe?= To: Wolfram Sang Cc: linux-i2c@vger.kernel.org, linux-sh@vger.kernel.org, Magnus Damm , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Pantelis Antoniou Date: Thu, 07 Jan 2016 17:56:38 +0100 In-Reply-To: <1452088285-6427-3-git-send-email-wsa@the-dreams.de> References: <1452088285-6427-1-git-send-email-wsa@the-dreams.de> <1452088285-6427-3-git-send-email-wsa@the-dreams.de> Organization: Pengutronix Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c3 X-SA-Exim-Mail-From: jlu@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Wolfram, On Mi, 2016-01-06 at 14:51 +0100, Wolfram Sang wrote: [...] > +Required properties: > +- compatible: "i2c-demux-pinctrl" > +- i2c-parent: List of phandles of I2C masters available for selection. The first > + one will be used as default. > +- i2c-bus-name: The name of this bus. Also needed as pinctrl-name for the I2C > + parents. [...] > + i2chdmi: i2c@8 { > + compatible = "i2c-demux-pinctrl"; > + i2c-parent = <&gpioi2c>, <&iic2>, <&i2c2>; > + i2c-bus-name = "i2c-hdmi"; > + #address-cells = <1>; > + #size-cells = <0>; [...] > + gpioi2c: i2c@9 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "i2c-gpio"; [...] > +&i2c2 { > + pinctrl-0 = <&i2c2_pins>; > + pinctrl-names = "i2c-hdmi"; > + > + clock-frequency = <100000>; > +}; [...] > +&iic2 { > + pinctrl-0 = <&iic2_pins>; > + pinctrl-names = "i2c-hdmi"; > + > + clock-frequency = <100000>; > +}; [...] It seems that the demux-pinctrl driver reconfigures the pinctrl settings for the parent devices. I would have expected to have alternative pinctrl state on the demux node support switching the same external pins between the different controllers. Wouldn't it be possible to have pinctrl conflicts between &i2c2_pins and &iic2_pins otherwise? Regards, Jan -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |