From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755535AbcAHT6w (ORCPT <rfc822;w@1wt.eu>);
	Fri, 8 Jan 2016 14:58:52 -0500
Received: from mga14.intel.com ([192.55.52.115]:28831 "EHLO mga14.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751213AbcAHT6u (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 8 Jan 2016 14:58:50 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,540,1444719600"; 
   d="scan'208";a="877548176"
From: "Jiang, Dave" <dave.jiang@intel.com>
To: "Williams, Dan J" <dan.j.williams@intel.com>,
        "tim.gardner@canonical.com" <tim.gardner@canonical.com>
CC: "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "der.herr@hofr.at" <der.herr@hofr.at>,
        "Koul, Vinod" <vinod.koul@intel.com>,
        "prarit@redhat.com" <prarit@redhat.com>,
        "jarkko.nikula@linux.intel.com" <jarkko.nikula@linux.intel.com>
Subject: Re: [PATCH v4.4-rc8 v3] dmaengine: ioatdma: Squelch framesize
 warnings
Thread-Topic: [PATCH v4.4-rc8 v3] dmaengine: ioatdma: Squelch framesize
 warnings
Thread-Index: AQHRSkp5uZsC01rYu0eg6+E/7MW/r57yiqOAgAAE2wA=
Date: Fri, 8 Jan 2016 19:58:47 +0000
Message-ID: <1452283126.3983.41.camel@intel.com>
References: <CAPcyv4iSKdGN_JnOuJkbfuZLjT5omFnHhAt38oiJngBRQcHOWA@mail.gmail.com>
	 <1452281139-32352-1-git-send-email-tim.gardner@canonical.com>
	 <CAPcyv4g_SeB2LDuv7=KEWithUwe_HgbUb5XzmnDuE+1DESAf4Q@mail.gmail.com>
In-Reply-To: <CAPcyv4g_SeB2LDuv7=KEWithUwe_HgbUb5XzmnDuE+1DESAf4Q@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [143.182.137.38]
Content-Type: text/plain; charset="utf-8"
Content-ID: <148CCE32D711C84EA96D0921DF3DEB6E@intel.com>
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u08Jwuha020749

On Fri, 2016-01-08 at 19:41 +0000, Williams, Dan J wrote:
> On Fri, Jan 8, 2016 at 11:25 AM,  <tim.gardner@canonical.com> wrote:
> > From: Tim Gardner <tim.gardner@canonical.com>
> > 
> >   CC [M]  drivers/dma/ioat/prep.o
> > drivers/dma/ioat/prep.c: In function 'ioat_prep_pqxor':
> > drivers/dma/ioat/prep.c:682:1: warning: the frame size of 1048
> > bytes is larger than 1024 bytes [-Wframe-larger-than=]
> >  }
> >  ^
> > drivers/dma/ioat/prep.c: In function 'ioat_prep_pqxor_val':
> > drivers/dma/ioat/prep.c:714:1: warning: the frame size of 1048
> > bytes is larger than 1024 bytes [-Wframe-larger-than=]
> >  }
> > 
> > gcc version 5.3.1 20151219 (Ubuntu 5.3.1-4ubuntu1)
> > 
> > Cc: Vinod Koul <vinod.koul@intel.com>
> > Cc: Dan Williams <dan.j.williams@intel.com>
> > Cc: Dave Jiang <dave.jiang@intel.com>
> > Cc: Prarit Bhargava <prarit@redhat.com>
> > Cc: Nicholas Mc Guire <der.herr@hofr.at>
> > Cc: Jarkko Nikula <jarkko.nikula@linux.intel.com>
> > Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
> > ---
> > 
> > v2 - use per CPU static buffers instead of dynamically allocating
> > memory.
> > v3 - Use get_cpu_var/put_cpu_var which implicitly control
> > preeemption. Drop
> >      the wrapper function that no longer serves any purpose.
> > 
> >  drivers/dma/ioat/prep.c | 29 +++++++++++++++++++++++++----
> >  1 file changed, 25 insertions(+), 4 deletions(-)
> 
> Looks good to me... but now that I think about it, why is MAX_SCF set
> to 1024 in the first place?  Certainly it can't be bigger than the
> maximum number of sources in a single operation which is 8 to 16.
> Even md raid can only support up to 256 devices in an array.  So I
> think that contstant is bogus.
> 
> If we set it to 16 we may not even need the percpu change.
> 
> Dave?

You are right. It was an arbitrary number I threw in there to address
sparse warning. It can be reduced. 256 seems reasonable.