From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755823AbcAHUAA (ORCPT ); Fri, 8 Jan 2016 15:00:00 -0500 Received: from smtprelay0009.hostedemail.com ([216.40.44.9]:34431 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755266AbcAHT76 (ORCPT ); Fri, 8 Jan 2016 14:59:58 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:2916:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3874:4250:4321:5007:6119:6261:8603:10004:10400:10848:11026:11232:11473:11658:11783:11914:12043:12296:12438:12517:12519:12740:13069:13095:13311:13357:13894:13972:14093:14097:14659:21080:30034:30045:30054:30064:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: size68_1c60094beb315 X-Filterd-Recvd-Size: 2352 Message-ID: <1452283193.4028.84.camel@perches.com> Subject: Re: [PATCH] ata: add AMD Seattle platform driver From: Joe Perches To: Brijesh Singh , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, tj@kernel.org, devicetree@vger.kernel.org, linux-ide@vger.kernel.org Date: Fri, 08 Jan 2016 11:59:53 -0800 In-Reply-To: <1452200002-31590-1-git-send-email-brijesh.singh@amd.com> References: <1452200002-31590-1-git-send-email-brijesh.singh@amd.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.3-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-01-07 at 14:53 -0600, Brijesh Singh wrote: > AMD Seattle SATA controller mostly conforms to AHCI interface with some > special register to control SGPIO interface. In the case of an AHCI > controller, the SGPIO feature is ideally implemented using the > "Enclosure Management" register of the AHCI controller, but those > registeres are not implemented in the Seattle SoC. Instead SoC > (Rev B0 onwards) provides a 32-bit SGPIO control register which should > be programmed to control the activity, locate and fault LEDs. trivia: > diff --git a/drivers/ata/ahci_seattle.c b/drivers/ata/ahci_seattle.c [] > +static ssize_t seattle_transmit_led_message(struct ata_port *ap, u32 state, > +     ssize_t size) > +{ > + struct ahci_host_priv *hpriv = ap->host->private_data; > + struct ahci_port_priv *pp = ap->private_data; > + struct seattle_plat_data *plat_data = hpriv->plat_data; > + unsigned long flags; > + int pmp; > + struct ahci_em_priv *emp; > + u32 val; > + > + /* get the slot number from the message */ > + pmp = (state & EM_MSG_LED_PMP_SLOT) >> 8; > + if (pmp < EM_MAX_SLOTS) > + emp = &pp->em_priv[pmp]; > + else > + return -EINVAL; This is generally done using a inverted test that returns immediately if (pmp >= EMP_MAX_SLOTS) return -EINVAL; emp = &pp->em_priv[pmp];