From: tim.gardner@canonical.com
To: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Tim Gardner <tim.gardner@canonical.com>,
Vinod Koul <vinod.koul@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
Prarit Bhargava <prarit@redhat.com>,
Nicholas Mc Guire <der.herr@hofr.at>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>
Subject: [PATCH v4.4-rc8 v4] dmaengine: ioatdma: Squelch framesize warnings
Date: Fri, 8 Jan 2016 14:48:17 -0700 [thread overview]
Message-ID: <1452289697-1737-1-git-send-email-tim.gardner@canonical.com> (raw)
In-Reply-To: <1452283126.3983.41.camel@intel.com>
From: Tim Gardner <tim.gardner@canonical.com>
CC [M] drivers/dma/ioat/prep.o
drivers/dma/ioat/prep.c: In function 'ioat_prep_pqxor':
drivers/dma/ioat/prep.c:682:1: warning: the frame size of 1048 bytes is larger than 1024 bytes [-Wframe-larger-than=]
}
^
drivers/dma/ioat/prep.c: In function 'ioat_prep_pqxor_val':
drivers/dma/ioat/prep.c:714:1: warning: the frame size of 1048 bytes is larger than 1024 bytes [-Wframe-larger-than=]
}
gcc version 5.3.1 20151219 (Ubuntu 5.3.1-4ubuntu1)
Cc: Vinod Koul <vinod.koul@intel.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Dave Jiang <dave.jiang@intel.com>
Cc: Prarit Bhargava <prarit@redhat.com>
Cc: Nicholas Mc Guire <der.herr@hofr.at>
Cc: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
---
v2 - use per CPU static buffers instead of dynamically allocating memory.
v3 - Use get_cpu_var/put_cpu_var which implicitly control preeemption. Drop
the wrapper function that no longer serves any purpose.
v4 - According to discussion between Dan Williams and Dave Jiang, MAX_SCF really
only needs to be 256. That is certainly a simpler patch then previous efforts.
Quoting from an email regarding v3:
Dan said, "Looks good to me... but now that I think about it, why is MAX_SCF set
to 1024 in the first place? Certainly it can't be bigger than the
maximum number of sources in a single operation which is 8 to 16.
Even md raid can only support up to 256 devices in an array. So I
think that contstant is bogus.
If we set it to 16 we may not even need the percpu change.
Dave?"
Dave responded, "You are right. It was an arbitrary number I threw in there to address
sparse warning. It can be reduced. 256 seems reasonable. "
drivers/dma/ioat/prep.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/ioat/prep.c b/drivers/dma/ioat/prep.c
index 6bb4a13..243421a 100644
--- a/drivers/dma/ioat/prep.c
+++ b/drivers/dma/ioat/prep.c
@@ -26,7 +26,7 @@
#include "hw.h"
#include "dma.h"
-#define MAX_SCF 1024
+#define MAX_SCF 256
/* provide a lookup table for setting the source address in the base or
* extended descriptor of an xor or pq descriptor
--
2.6.4
next prev parent reply other threads:[~2016-01-08 21:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 18:07 [PATCH v4.4-rc8] dmaengine: ioatdma: Squelch framesize warnings tim.gardner
2016-01-07 19:45 ` Dan Williams
2016-01-08 13:35 ` [PATCH v4.4-rc8 v2] " tim.gardner
2016-01-08 16:39 ` Dan Williams
2016-01-08 19:25 ` [PATCH v4.4-rc8 v3] " tim.gardner
2016-01-08 19:41 ` Dan Williams
2016-01-08 19:58 ` Jiang, Dave
2016-01-08 21:48 ` tim.gardner [this message]
2016-01-13 13:28 ` [PATCH v4.4-rc8 v4] " Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452289697-1737-1-git-send-email-tim.gardner@canonical.com \
--to=tim.gardner@canonical.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=der.herr@hofr.at \
--cc=dmaengine@vger.kernel.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=prarit@redhat.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox