From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756645AbcAIQiR (ORCPT ); Sat, 9 Jan 2016 11:38:17 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:43725 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932136AbcAIQhN (ORCPT ); Sat, 9 Jan 2016 11:37:13 -0500 From: Guenter Roeck To: "David S. Miller" Cc: adi-buildroot-devel@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Guenter Roeck , Andrew Lunn Subject: [PATCH -next 1/2] net: bfin_mac: Fix error handling in probe function Date: Sat, 9 Jan 2016 08:37:06 -0800 Message-Id: <1452357427-30578-1-git-send-email-linux@roeck-us.net> X-Mailer: git-send-email 2.1.4 X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit e7f4dc3536a4 ("mdio: Move allocation of interrupts into core") removed interrupt allocation code. While doing so, error handling got messed up a bit, resulting in the following build warning and a missed call to mdiobus_free() in the probe function error path. drivers/net/ethernet/adi/bfin_mac.c: In function 'bfin_mii_bus_probe': drivers/net/ethernet/adi/bfin_mac.c:1865:1: warning: label 'out_err_irq_alloc' defined but not used Fixes: e7f4dc3536a4 ("mdio: Move allocation of interrupts into core") Cc: Andrew Lunn Signed-off-by: Guenter Roeck --- drivers/net/ethernet/adi/bfin_mac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/adi/bfin_mac.c b/drivers/net/ethernet/adi/bfin_mac.c index 62862744c870..8c5132624510 100644 --- a/drivers/net/ethernet/adi/bfin_mac.c +++ b/drivers/net/ethernet/adi/bfin_mac.c @@ -1856,13 +1856,13 @@ static int bfin_mii_bus_probe(struct platform_device *pdev) rc = mdiobus_register(miibus); if (rc) { dev_err(&pdev->dev, "Cannot register MDIO bus!\n"); - goto out_err_alloc; + goto out_err_mdiobus_register; } platform_set_drvdata(pdev, miibus); return 0; -out_err_irq_alloc: +out_err_mdiobus_register: mdiobus_free(miibus); out_err_alloc: peripheral_free_list(pin_req); -- 2.1.4