From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755594AbcAIRei (ORCPT ); Sat, 9 Jan 2016 12:34:38 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:45317 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755159AbcAIReg convert rfc822-to-8bit (ORCPT ); Sat, 9 Jan 2016 12:34:36 -0500 Message-Id: <1452360875.672905.487413202.45C93A5C@webmail.messagingengine.com> X-Sasl-Enc: CNalNLOLX/V/fj8KXG9wxeLaWM/RAnsoaLr+t9IVy2ke 1452360875 From: Henrique de Moraes Holschuh To: Darren Hart , =?ISO-8859-1?Q?Pali=20Roh=E1r?= Cc: ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, "Fabio D'Urso" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: MessagingEngine.com Webmail Interface - ajax-6cda141f In-Reply-To: <20160104204020.GC4219@malice.jf.intel.com> References: <1450982818-11694-1-git-send-email-pali.rohar@gmail.com> <1451514461-31999-1-git-send-email-pali.rohar@gmail.com> <20160104200425.GC26072@malice.jf.intel.com> <201601042126.19417@pali> <20160104204020.GC4219@malice.jf.intel.com> Subject: Re: [PATCH v2] thinkpad_acpi: Add support for keyboard backlight Date: Sat, 09 Jan 2016 15:34:35 -0200 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 4, 2016, at 18:40, Darren Hart wrote: > On Mon, Jan 04, 2016 at 09:26:19PM +0100, Pali Rohár wrote: > > On Monday 04 January 2016 21:04:25 Darren Hart wrote: > > > On Wed, Dec 30, 2015 at 11:27:41PM +0100, Pali Rohár wrote: > > > > This patch adds support for controlling keyboard backlight via > > > > standard linux led class interface (::kbd_backlight). It uses ACPI > > > > HKEY device with MLCG and MLCS methods. > > > > > > Which laptops is this intended to support? > > > > Thinkpad ??30 series and new which have backlight keyboard. > > Thanks, we should include that in the commit message as well as the > comments > surrounding the driver section. > > Henrique, are your concerns surrounding suspend/resume resolved? Yes. Acked-by: Henrique de Moraes Holschuh -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh