From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755918AbcAIRgT (ORCPT ); Sat, 9 Jan 2016 12:36:19 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:49832 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754332AbcAIRgR convert rfc822-to-8bit (ORCPT ); Sat, 9 Jan 2016 12:36:17 -0500 Message-Id: <1452360976.673310.487413586.60AA12B9@webmail.messagingengine.com> X-Sasl-Enc: nSBFMFpq1XW3AV4Cg3ZtMuHh9RZbIq9PA5LL1iTXrazT 1452360976 From: Henrique de Moraes Holschuh To: =?ISO-8859-1?Q?Pali=20Roh=E1r?= Cc: Darren Hart , ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, "Fabio D'Urso" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: MessagingEngine.com Webmail Interface - ajax-6cda141f In-Reply-To: <20160106084513.GA11364@pali> References: <1450982818-11694-1-git-send-email-pali.rohar@gmail.com> <20151227231417.GB8731@khazad-dum.debian.net> <201512281548.14411@pali> <201512302328.48620@pali> <20160106084513.GA11364@pali> Subject: Re: [PATCH] thinkpad_acpi: Add support for keyboard backlight Date: Sat, 09 Jan 2016 15:36:16 -0200 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 6, 2016, at 06:45, Pali Rohár wrote: > On Wednesday 30 December 2015 23:28:48 Pali Rohár wrote: > > On Monday 28 December 2015 15:48:14 Pali Rohár wrote: > > > > Also, is it working properly across suspend+resume? > > > > > > When doing resume from suspend or hibernate BIOS turning keyboard > > > backlight automatically off. > > > > Fixed in v2. > > > > Now I see that BIOS try to be too intelligent and automatically turn of > keyboard backlight when LID is closed. When LID is open again then > keyboard backlight stay turned off. Sysfs show correct state (brightness > is zero). > > Should thinkpad acpi driver do something? Or let BIOS do that job? Either is fine, as long as you ensure the driver knows the BIOS turned off the backlight, which you did. So, really, I don't mind if we follow the BIOS. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh