From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755799AbcAIRqp (ORCPT ); Sat, 9 Jan 2016 12:46:45 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:43117 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755493AbcAIRqm convert rfc822-to-8bit (ORCPT ); Sat, 9 Jan 2016 12:46:42 -0500 Message-Id: <1452361601.676356.487415834.4652D305@webmail.messagingengine.com> X-Sasl-Enc: 8QfrQvVEvAlPzeGI3LbdJdo8ayyR7JKiXIjfydA5wGiW 1452361601 From: Henrique de Moraes Holschuh To: Pavel Machek , =?ISO-8859-1?Q?Pali=20Roh=E1r?= Cc: Darren Hart , ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, "Fabio D'Urso" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: MessagingEngine.com Webmail Interface - ajax-6cda141f In-Reply-To: <1452361154.673684.487414482.6CCEAE4B@webmail.messagingengine.com> References: <1450982818-11694-1-git-send-email-pali.rohar@gmail.com> <20160104201231.GB5847@amd> <1452361154.673684.487414482.6CCEAE4B@webmail.messagingengine.com> Subject: Re: [PATCH] thinkpad_acpi: Add support for keyboard backlight Date: Sat, 09 Jan 2016 15:46:41 -0200 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 9, 2016, at 15:39, Henrique de Moraes Holschuh wrote: > On Mon, Jan 4, 2016, at 18:12, Pavel Machek wrote: > > > This patch adds support for controlling keyboard backlight via standard > > > linux led class interface (::kbd_backlight). It uses ACPI HKEY device with > > > MLCG and MLCS methods. > > > > > > Signed-off-by: Pali Rohár > > > Tested-by: Fabio D'Urso > > > > On my thinkpad, keyboard light is controlled by > > > > /sys/class/leds/tpacpi\:\:thinklight/brightness > > > > (that's a bad name). > > That's because the driver was not updated to support your laptop, AND I > don't recall if someone mapped the full behavior of the ACPI thinklight > interface in your thinkpad :-( Argh. If by "keyboard light" you mean the LED above the *screen* that shines down on the whole keyboard, please disregard my previous reply... As for the naming, the idea of a LED up there shining in the keyboard is: 1. patented by IBM 2. named "ThinkLight" by IBM, one of the "Think Technologies" in the "ThinkPad" (add TM after everything :p) and every old-timer thinkpad user knew it by that name. 4. called "thinklight" by the driver since before the LED sysfs class even existed :p ibm-acpi, since then renamed thinkpad-acpi *predates* most generic interfaces. Heck, it predates sysfs. So, this is ABI set in stone. If there is a way to add an "alias" of kbd_backlight that won't drive userspace crazy, we might do that though. But it looks quite risky to me... -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh