From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Anton Wuerfel <anton.wuerfel@fau.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.com>,
"James E.J. Bottomley" <jejb@parisc-linux.org>,
Helge Deller <deller@gmx.de>,
Peter Hurley <peter@hurleysoftware.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Qipeng Zha <qipeng.zha@intel.com>,
Desmond Liu <desmondl@broadcom.com>,
Wang Long <long.wanglong@huawei.com>,
Matt Redfearn <matt.redfearn@imgtec.com>,
Paul Burton <paul.burton@imgtec.com>,
Ralf Baechle <ralf@linux-mips.org>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Peter Hung <hpeter@gmail.com>,
Soeren Grunewald <soeren.grunewald@desy.de>,
Adam Lee <adam.lee@canonical.com>,
"Maciej S. Szmigiero" <mail@maciej.szmigiero.name>,
Mans Rullgard <mans@mansr.com>,
linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org,
linux-kernel@i4.cs.fau.de, phillip.raffeck@fau.de
Subject: Re: [PATCH v4 01/13] tty: serial: 8250: Fix whitespace errors
Date: Mon, 11 Jan 2016 14:28:14 +0200 [thread overview]
Message-ID: <1452515294.26146.10.camel@linux.intel.com> (raw)
In-Reply-To: <1452275039-18787-2-git-send-email-anton.wuerfel@fau.de>
On Fri, 2016-01-08 at 18:43 +0100, Anton Wuerfel wrote:
> This patch fixes whitespace errors reported by checkpatch to increase
> readability. Main focus is on missing spaces after commas in
> function headers and macros (like foo,bar edited to foo, bar).
>
> Signed-off-by: Anton Würfel <anton.wuerfel@fau.de>
> Signed-off-by: Phillip Raffeck <phillip.raffeck@fau.de>
> CC: linux-kernel@i4.cs.fau.de
Cc: looks more standard.
> --- a/drivers/tty/serial/8250/8250_accent.c
> +++ b/drivers/tty/serial/8250/8250_accent.c
> @@ -10,7 +10,7 @@
> #include <linux/init.h>
> #include <linux/serial_8250.h>
>
> -#define PORT(_base,_irq) \
> +#define PORT(_base, _irq) \
> { \
> .iobase = _base, \
> .irq = _irq, \
>
While those are okay, I would suggest to make a macro in
drivers/…/8250.h one for all, something like this:
#define 8250_PORT_FLAGS(_base, _irq, _flags)
…
.flags = UPF_BOOT_AUTOCONF | (_flags) \
#define 8250_PORT(_base, _irq) 8250_PORT_FLAGS(_base, _irq, 0)
And use it.
> --- a/drivers/tty/serial/8250/8250_boca.c
> +++ b/drivers/tty/serial/8250/8250_boca.c
> @@ -10,7 +10,7 @@
> #include <linux/init.h>
> #include <linux/serial_8250.h>
>
> -#define PORT(_base,_irq) \
> +#define PORT(_base, _irq) \
> { \
> .iobase = _base, \
> .irq = _irq, \
>
> --- a/drivers/tty/serial/8250/8250_exar_st16c554.c
> +++ b/drivers/tty/serial/8250/8250_exar_st16c554.c
> @@ -13,7 +13,7 @@
> #include <linux/init.h>
> #include <linux/serial_8250.h>
>
> -#define PORT(_base,_irq) \
> +#define PORT(_base, _irq) \
> { \
> .iobase = _base, \
> .irq = _irq, \
>
> --- a/drivers/tty/serial/8250/8250_fourport.c
> +++ b/drivers/tty/serial/8250/8250_fourport.c
> @@ -10,7 +10,7 @@
> #include <linux/init.h>
> #include <linux/serial_8250.h>
>
> -#define PORT(_base,_irq)
> \
> +#define PORT(_base, _irq)
> \
> {
> \
> .iobase = _base,
> \
> .irq = _irq,
> \
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2016-01-11 12:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 17:43 [PATCH v4 00/13] tty: serial: 8250: Fix checkpatch warnings Anton Wuerfel
2016-01-08 17:43 ` [PATCH v4 01/13] tty: serial: 8250: Fix whitespace errors Anton Wuerfel
2016-01-11 12:28 ` Andy Shevchenko [this message]
2016-01-11 12:50 ` Shevchenko, Andriy
2016-01-11 12:54 ` Måns Rullgård
2016-01-11 13:03 ` Shevchenko, Andriy
2016-01-08 17:43 ` [PATCH v4 02/13] tty: serial: 8250: Replace spaces with tabs Anton Wuerfel
2016-01-08 17:43 ` [PATCH v4 03/13] tty: serial: 8250: Fix braces after struct Anton Wuerfel
2016-01-08 17:43 ` [PATCH v4 04/13] tty: serial: 8250: Fix multiline comment style Anton Wuerfel
2016-01-08 17:43 ` [PATCH v4 05/13] tty: serial: 8250: Remove else after return Anton Wuerfel
2016-01-11 12:30 ` Andy Shevchenko
2016-01-08 17:43 ` [PATCH v4 06/13] tty: serial: 8250: Move EXPORT_SYMBOL to function Anton Wuerfel
2016-01-08 17:43 ` [PATCH v4 07/13] tty: serial: 8250: Fix line continuation warning Anton Wuerfel
2016-01-08 17:43 ` [PATCH v4 08/13] tty: serial: 8250: Add parentheses to macro Anton Wuerfel
2016-01-08 17:43 ` [PATCH v4 09/13] tty: serial: 8250: Fix multi-line strings Anton Wuerfel
2016-01-08 17:43 ` [PATCH v4 10/13] tty: serial: 8250: Suitably replace printk Anton Wuerfel
2016-01-11 12:38 ` Andy Shevchenko
2016-01-08 17:43 ` [PATCH v4 11/13] tty: serial: 8250: Remove SERIAL_DEBUG_PNP macro Anton Wuerfel
2016-01-08 17:43 ` [PATCH v4 12/13] tty: serial: 8250: Removed warning in debug output Anton Wuerfel
2016-01-11 12:42 ` Andy Shevchenko
2016-01-08 17:43 ` [PATCH v4 13/13] tty: serial: 8250: Fix indentation warnings Anton Wuerfel
2016-01-11 12:47 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452515294.26146.10.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=adam.lee@canonical.com \
--cc=anton.wuerfel@fau.de \
--cc=deller@gmx.de \
--cc=desmondl@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=hpeter@gmail.com \
--cc=jejb@parisc-linux.org \
--cc=jslaby@suse.com \
--cc=k.kozlowski@samsung.com \
--cc=linux-kernel@i4.cs.fau.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=long.wanglong@huawei.com \
--cc=mail@maciej.szmigiero.name \
--cc=mans@mansr.com \
--cc=matt.redfearn@imgtec.com \
--cc=paul.burton@imgtec.com \
--cc=peter@hurleysoftware.com \
--cc=phillip.raffeck@fau.de \
--cc=qipeng.zha@intel.com \
--cc=ralf@linux-mips.org \
--cc=soeren.grunewald@desy.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).