From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1759162AbcAKM14 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 11 Jan 2016 07:27:56 -0500
Received: from mga01.intel.com ([192.55.52.88]:48090 "EHLO mga01.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751942AbcAKM1x (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 11 Jan 2016 07:27:53 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,552,1444719600"; 
   d="scan'208";a="890772850"
Message-ID: <1452515294.26146.10.camel@linux.intel.com>
Subject: Re: [PATCH v4 01/13] tty: serial: 8250: Fix whitespace errors
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Anton Wuerfel <anton.wuerfel@fau.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.com>,
        "James E.J. Bottomley" <jejb@parisc-linux.org>,
        Helge Deller <deller@gmx.de>, Peter Hurley <peter@hurleysoftware.com>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Qipeng Zha <qipeng.zha@intel.com>, Desmond Liu <desmondl@broadcom.com>,
        Wang Long <long.wanglong@huawei.com>,
        Matt Redfearn <matt.redfearn@imgtec.com>,
        Paul Burton <paul.burton@imgtec.com>,
        Ralf Baechle <ralf@linux-mips.org>,
        Krzysztof Kozlowski <k.kozlowski@samsung.com>,
        Peter Hung <hpeter@gmail.com>,
        Soeren Grunewald <soeren.grunewald@desy.de>,
        Adam Lee <adam.lee@canonical.com>,
        "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>,
        Mans Rullgard <mans@mansr.com>, linux-kernel@vger.kernel.org,
        linux-parisc@vger.kernel.org, linux-kernel@i4.cs.fau.de,
        phillip.raffeck@fau.de
Date: Mon, 11 Jan 2016 14:28:14 +0200
In-Reply-To: <1452275039-18787-2-git-send-email-anton.wuerfel@fau.de>
References: <1452275039-18787-1-git-send-email-anton.wuerfel@fau.de>
	 <1452275039-18787-2-git-send-email-anton.wuerfel@fau.de>
Organization: Intel Finland Oy
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.18.3-1 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 2016-01-08 at 18:43 +0100, Anton Wuerfel wrote:
> This patch fixes whitespace errors reported by checkpatch to increase
> readability. Main focus is on missing spaces after commas in
> function headers and macros (like foo,bar edited to foo, bar).
> 
> Signed-off-by: Anton Würfel <anton.wuerfel@fau.de>
> Signed-off-by: Phillip Raffeck <phillip.raffeck@fau.de>
> CC: linux-kernel@i4.cs.fau.de

Cc: looks more standard.

> --- a/drivers/tty/serial/8250/8250_accent.c
> +++ b/drivers/tty/serial/8250/8250_accent.c
> @@ -10,7 +10,7 @@
>  #include <linux/init.h>
>  #include <linux/serial_8250.h>
>  
> -#define PORT(_base,_irq)				\
> +#define PORT(_base, _irq)				\
>  	{						\
>  		.iobase		= _base,		\
>  		.irq		= _irq,			\
> 

While those are okay, I would suggest to make a macro in
drivers/…/8250.h one for all, something like this:

#define 8250_PORT_FLAGS(_base, _irq, _flags)
…
	.flags          = UPF_BOOT_AUTOCONF | (_flags) \

#define 8250_PORT(_base, _irq)	8250_PORT_FLAGS(_base, _irq, 0)

And use it.

> --- a/drivers/tty/serial/8250/8250_boca.c
> +++ b/drivers/tty/serial/8250/8250_boca.c
> @@ -10,7 +10,7 @@
>  #include <linux/init.h>
>  #include <linux/serial_8250.h>
>  
> -#define PORT(_base,_irq)				\
> +#define PORT(_base, _irq)				\
>  	{						\
>  		.iobase		= _base,		\
>  		.irq		= _irq,			\
> 

> --- a/drivers/tty/serial/8250/8250_exar_st16c554.c
> +++ b/drivers/tty/serial/8250/8250_exar_st16c554.c
> @@ -13,7 +13,7 @@
>  #include <linux/init.h>
>  #include <linux/serial_8250.h>
>  
> -#define PORT(_base,_irq)				\
> +#define PORT(_base, _irq)				\
>  	{						\
>  		.iobase		= _base,		\
>  		.irq		= _irq,			\
> 

> --- a/drivers/tty/serial/8250/8250_fourport.c
> +++ b/drivers/tty/serial/8250/8250_fourport.c
> @@ -10,7 +10,7 @@
>  #include <linux/init.h>
>  #include <linux/serial_8250.h>
>  
> -#define PORT(_base,_irq)						
> \
> +#define PORT(_base, _irq)						
> \
>  	{								
> \
>  		.iobase		= _base,			
> 	\
>  		.irq		= _irq,				
> 	\



-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy