From: Lee Jones <lee.jones@linaro.org>
To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: kernel@stlinux.com, maxime.coquelin@st.com, ohad@wizery.com,
devicetree@vger.kernel.org, Nathan_Lynch@mentor.com,
f.fainelli@gmail.com, ludovic.barre@st.com, s-anna@ti.com,
Lee Jones <lee.jones@linaro.org>
Subject: [PATCH v5 1/7] remoteproc: debugfs: Check of invalid 'count' value
Date: Tue, 12 Jan 2016 12:46:15 +0000 [thread overview]
Message-ID: <1452602781-22424-2-git-send-email-lee.jones@linaro.org> (raw)
In-Reply-To: <1452602781-22424-1-git-send-email-lee.jones@linaro.org>
If 'count' value is invalid, return early with an error.
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/remoteproc/remoteproc_debugfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/remoteproc/remoteproc_debugfs.c b/drivers/remoteproc/remoteproc_debugfs.c
index 9d30809..f63464c 100644
--- a/drivers/remoteproc/remoteproc_debugfs.c
+++ b/drivers/remoteproc/remoteproc_debugfs.c
@@ -156,8 +156,8 @@ rproc_recovery_write(struct file *filp, const char __user *user_buf,
char buf[10];
int ret;
- if (count > sizeof(buf))
- return count;
+ if (count > sizeof(buf) || count <= 0)
+ return -EINVAL;
ret = copy_from_user(buf, user_buf, count);
if (ret)
--
1.9.1
next prev parent reply other threads:[~2016-01-12 12:49 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-12 12:46 [PATCH v5 0/7] remoteproc: Add driver for STMicroelectronics platforms Lee Jones
2016-01-12 12:46 ` Lee Jones [this message]
2016-01-12 12:46 ` [PATCH v5 2/7] remoteproc: dt: Provide bindings for ST's Remote Processor Controller driver Lee Jones
2016-01-12 14:33 ` Rob Herring
2016-01-12 14:46 ` Lee Jones
2016-03-16 16:39 ` [STLinux Kernel] " Peter Griffin
2016-01-12 12:46 ` [PATCH v5 3/7] remoteproc: debugfs: Add ability to boot remote processor using debugfs Lee Jones
2016-03-16 16:44 ` [STLinux Kernel] " Peter Griffin
2016-01-12 12:46 ` [PATCH v5 4/7] remoteproc: Supply controller driver for ST's Remote Processors Lee Jones
2016-01-12 14:47 ` Lee Jones
2016-03-16 16:38 ` [STLinux Kernel] " Peter Griffin
2016-01-12 12:46 ` [PATCH v5 5/7] MAINTAINERS: Add ST's Remote Processor Driver to ARM/STI ARCHITECTURE Lee Jones
2016-03-16 16:40 ` [STLinux Kernel] " Peter Griffin
2016-01-12 12:46 ` [PATCH v5 6/7] ARM: STiH407: Add nodes for RemoteProc Lee Jones
2016-04-13 22:04 ` Olof Johansson
2016-01-12 12:46 ` [PATCH v5 7/7] ARM: STiH407: Move over to using the 'reserved-memory' API for obtaining DMA memory Lee Jones
2016-03-16 16:35 ` [STLinux Kernel] " Peter Griffin
2016-03-16 16:55 ` Lee Jones
2016-03-16 20:10 ` Peter Griffin
2016-03-17 9:05 ` Loic PALLARDY
2016-03-17 10:18 ` Lee Jones
2016-01-27 7:31 ` [PATCH v5 0/7] remoteproc: Add driver for STMicroelectronics platforms Lee Jones
2016-01-27 19:19 ` Bjorn Andersson
2016-03-02 15:43 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452602781-22424-2-git-send-email-lee.jones@linaro.org \
--to=lee.jones@linaro.org \
--cc=Nathan_Lynch@mentor.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=kernel@stlinux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.barre@st.com \
--cc=maxime.coquelin@st.com \
--cc=ohad@wizery.com \
--cc=s-anna@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).