From: Lubomir Rintel <lkundrak@v3.sk>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Jamal Hadi Salim <jhs@mojatatu.com>
Subject: Re: [PATCH 1/3] ifb: make device count build-time configurable
Date: Tue, 12 Jan 2016 16:43:49 +0100 [thread overview]
Message-ID: <1452613429.18559.69.camel@v3.sk> (raw)
In-Reply-To: <56951D49.5020800@iogearbox.net>
On Tue, 2016-01-12 at 16:35 +0100, Daniel Borkmann wrote:
> On 01/12/2016 04:19 PM, Daniel Borkmann wrote:
> > On 01/12/2016 12:56 PM, Lubomir Rintel wrote:
...
> > > -static int numifbs = 2;
> > ^^^^^^^^^^^^
> > > +static int numifbs = CONFIG_IFB_COUNT;
> > > module_param(numifbs, int, 0);
> > > MODULE_PARM_DESC(numifbs, "Number of ifb devices");
>
> Btw, perhaps there should also be a pr_info() or the like to warn the user
> that relying on modprobe creating these devs is deprecated and scheduled
> for removal in future, so they should switch to ip link instead ...
I don't know, is it actually is scheduled for removal?
I was under impression that changes in default behavior users can rely
on are generally near impossible to do since the potential problems
largely outweigh the benefits. The distributions will do the changes in
their kernels anyway and changing behavior on kernel upgrades in random
old systems might be risky.
That said, it's just an impression. I don't follow the development
closely enough to be sure about anything.
Lubo
next prev parent reply other threads:[~2016-01-12 15:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-12 11:56 [PATCH 1/3] ifb: make device count build-time configurable Lubomir Rintel
2016-01-12 12:55 ` Jamal Hadi Salim
2016-01-12 18:44 ` Stephen Hemminger
2016-01-12 20:54 ` David Miller
2016-02-05 15:02 ` Lubomir Rintel
2016-01-12 15:10 ` Tom Gundersen
2016-01-12 15:19 ` Daniel Borkmann
2016-01-12 15:31 ` Lubomir Rintel
2016-01-12 15:36 ` [PATCH v2] " Lubomir Rintel
2016-01-12 20:42 ` David Miller
2016-01-12 15:35 ` [PATCH 1/3] " Daniel Borkmann
2016-01-12 15:43 ` Lubomir Rintel [this message]
2016-01-12 16:04 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452613429.18559.69.camel@v3.sk \
--to=lkundrak@v3.sk \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox