* [PATCH] drm/panel: simple: Add support for Sharp LQ101K1LY04
@ 2016-01-12 16:05 Joshua Clayton
2016-01-12 17:41 ` Joshua Clayton
2016-01-12 18:45 ` Lucas Stach
0 siblings, 2 replies; 4+ messages in thread
From: Joshua Clayton @ 2016-01-12 16:05 UTC (permalink / raw)
To: Thierry Reding, David Airlie; +Cc: dri-devel, linux-kernel
Sharp LQ101K1LY04 is a 10 inch WXGA (1280x800) lvds panel
---
drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index f97b73e..9207b5d 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -708,6 +708,29 @@ static const struct panel_desc giantplus_gpg482739qs5 = {
.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
};
+static const struct display_timing sharp_lq101k1ly04_timing = {
+ .pixelclock = { 60000000, 65000000, 80000000 },
+ .hactive = { 1280, 1280, 1280 },
+ .hfront_porch = { 20, 20, 20 },
+ .hback_porch = { 20, 20, 20 },
+ .hsync_len = { 10, 10, 10 },
+ .vactive = { 800, 800, 800 },
+ .vfront_porch = { 4, 4, 4 },
+ .vback_porch = { 4, 4, 4 },
+ .vsync_len = { 4, 4, 4 },
+ .flags = DISPLAY_FLAGS_PIXDATA_POSEDGE,
+};
+static const struct panel_desc sharp_lq101k1ly04 = {
+ .timings = &sharp_lq101k1ly04_timing,
+ .num_timings = 1,
+ .bpc = 8,
+ .size = {
+ .width = 217,
+ .height = 136,
+ },
+ .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA,
+};
+
static const struct display_timing hannstar_hsd070pww1_timing = {
.pixelclock = { 64300000, 71100000, 82000000 },
.hactive = { 1280, 1280, 1280 },
@@ -1146,6 +1169,9 @@ static const struct of_device_id platform_of_match[] = {
.compatible = "hannstar,hsd070pww1",
.data = &hannstar_hsd070pww1,
}, {
+ .compatible = "sharp,lq101k1ly04",
+ .data = &sharp_lq101k1ly04,
+ }, {
.compatible = "hannstar,hsd100pxn1",
.data = &hannstar_hsd100pxn1,
}, {
--
2.5.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] drm/panel: simple: Add support for Sharp LQ101K1LY04
2016-01-12 16:05 [PATCH] drm/panel: simple: Add support for Sharp LQ101K1LY04 Joshua Clayton
@ 2016-01-12 17:41 ` Joshua Clayton
2016-01-12 18:45 ` Lucas Stach
1 sibling, 0 replies; 4+ messages in thread
From: Joshua Clayton @ 2016-01-12 17:41 UTC (permalink / raw)
To: Thierry Reding, David Airlie; +Cc: dri-devel, linux-kernel
On Tue, 12 Jan 2016 08:05:46 -0800
Joshua Clayton <stillcompiling@gmail.com> wrote:
Bah. I mistakenly thought that send-email would add my SoB
if I passed "-s" to git-send-email.
> Sharp LQ101K1LY04 is a 10 inch WXGA (1280x800) lvds panel
>
Please add:
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
> ---
> drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c
> b/drivers/gpu/drm/panel/panel-simple.c index f97b73e..9207b5d 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -708,6 +708,29 @@ static const struct panel_desc
> giantplus_gpg482739qs5 = { .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> };
>
> +static const struct display_timing sharp_lq101k1ly04_timing = {
> + .pixelclock = { 60000000, 65000000, 80000000 },
> + .hactive = { 1280, 1280, 1280 },
> + .hfront_porch = { 20, 20, 20 },
> + .hback_porch = { 20, 20, 20 },
> + .hsync_len = { 10, 10, 10 },
> + .vactive = { 800, 800, 800 },
> + .vfront_porch = { 4, 4, 4 },
> + .vback_porch = { 4, 4, 4 },
> + .vsync_len = { 4, 4, 4 },
> + .flags = DISPLAY_FLAGS_PIXDATA_POSEDGE,
> +};
> +static const struct panel_desc sharp_lq101k1ly04 = {
> + .timings = &sharp_lq101k1ly04_timing,
> + .num_timings = 1,
> + .bpc = 8,
> + .size = {
> + .width = 217,
> + .height = 136,
> + },
> + .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA,
> +};
> +
> static const struct display_timing hannstar_hsd070pww1_timing = {
> .pixelclock = { 64300000, 71100000, 82000000 },
> .hactive = { 1280, 1280, 1280 },
> @@ -1146,6 +1169,9 @@ static const struct of_device_id
> platform_of_match[] = { .compatible = "hannstar,hsd070pww1",
> .data = &hannstar_hsd070pww1,
> }, {
> + .compatible = "sharp,lq101k1ly04",
> + .data = &sharp_lq101k1ly04,
> + }, {
> .compatible = "hannstar,hsd100pxn1",
> .data = &hannstar_hsd100pxn1,
> }, {
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/panel: simple: Add support for Sharp LQ101K1LY04
2016-01-12 16:05 [PATCH] drm/panel: simple: Add support for Sharp LQ101K1LY04 Joshua Clayton
2016-01-12 17:41 ` Joshua Clayton
@ 2016-01-12 18:45 ` Lucas Stach
2016-01-12 20:40 ` Joshua Clayton
1 sibling, 1 reply; 4+ messages in thread
From: Lucas Stach @ 2016-01-12 18:45 UTC (permalink / raw)
To: Joshua Clayton, Thierry Reding, David Airlie; +Cc: linux-kernel, dri-devel
Hi Joshua,
Am Dienstag, den 12.01.2016, 08:05 -0800 schrieb Joshua Clayton:
> Sharp LQ101K1LY04 is a 10 inch WXGA (1280x800) lvds panel
>
> ---
> drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++
Missing documentation for the DT binding.
> 1 file changed, 26 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c
> b/drivers/gpu/drm/panel/panel-simple.c
> index f97b73e..9207b5d 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -708,6 +708,29 @@ static const struct panel_desc
> giantplus_gpg482739qs5 = {
> .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> };
>
> +static const struct display_timing sharp_lq101k1ly04_timing = {
> + .pixelclock = { 60000000, 65000000, 80000000 },
> + .hactive = { 1280, 1280, 1280 },
> + .hfront_porch = { 20, 20, 20 },
> + .hback_porch = { 20, 20, 20 },
> + .hsync_len = { 10, 10, 10 },
> + .vactive = { 800, 800, 800 },
> + .vfront_porch = { 4, 4, 4 },
> + .vback_porch = { 4, 4, 4 },
> + .vsync_len = { 4, 4, 4 },
> + .flags = DISPLAY_FLAGS_PIXDATA_POSEDGE,
> +};
> +static const struct panel_desc sharp_lq101k1ly04 = {
> + .timings = &sharp_lq101k1ly04_timing,
> + .num_timings = 1,
> + .bpc = 8,
> + .size = {
> + .width = 217,
> + .height = 136,
> + },
> + .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA,
> +};
> +
This hunk isn't added at the correct place. Please keep the
alphabetical sorting.
> static const struct display_timing hannstar_hsd070pww1_timing = {
> .pixelclock = { 64300000, 71100000, 82000000 },
> .hactive = { 1280, 1280, 1280 },
> @@ -1146,6 +1169,9 @@ static const struct of_device_id
> platform_of_match[] = {
> .compatible = "hannstar,hsd070pww1",
> .data = &hannstar_hsd070pww1,
> }, {
> + .compatible = "sharp,lq101k1ly04",
> + .data = &sharp_lq101k1ly04,
> + }, {
Wrong insertion place again.
> .compatible = "hannstar,hsd100pxn1",
> .data = &hannstar_hsd100pxn1,
> }, {
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/panel: simple: Add support for Sharp LQ101K1LY04
2016-01-12 18:45 ` Lucas Stach
@ 2016-01-12 20:40 ` Joshua Clayton
0 siblings, 0 replies; 4+ messages in thread
From: Joshua Clayton @ 2016-01-12 20:40 UTC (permalink / raw)
To: Lucas Stach; +Cc: Thierry Reding, David Airlie, linux-kernel, dri-devel
Hi Lucas,
Thanks for the review.
On Tue, 12 Jan 2016 19:45:30 +0100
Lucas Stach <dev@lynxeye.de> wrote:
> > drivers/gpu/drm/panel/panel-simple.c | 26
> > ++++++++++++++++++++++++++
>
> Missing documentation for the DT binding.
>
Thanks, will add.
...
> > + .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA,
> > +};
> > +
> This hunk isn't added at the correct place. Please keep the
> alphabetical sorting.
OK. Makes sense. I'll reorder these.
>
> > static const struct display_timing hannstar_hsd070pww1_timing = {
> > .pixelclock = { 64300000, 71100000, 82000000 },
> > .hactive = { 1280, 1280, 1280 },
> > @@ -1146,6 +1169,9 @@ static const struct of_device_id
> > platform_of_match[] = {
> > .compatible = "hannstar,hsd070pww1",
> > .data = &hannstar_hsd070pww1,
> > }, {
> > + .compatible = "sharp,lq101k1ly04",
> > + .data = &sharp_lq101k1ly04,
> > + }, {
>
> Wrong insertion place again.
OK. Will reorder alphabetically also.
Joshua
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-01-12 20:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-12 16:05 [PATCH] drm/panel: simple: Add support for Sharp LQ101K1LY04 Joshua Clayton
2016-01-12 17:41 ` Joshua Clayton
2016-01-12 18:45 ` Lucas Stach
2016-01-12 20:40 ` Joshua Clayton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox