Re: [PATCH] drm/panel: simple: Add support for Sharp LQ101K1LY04

[Lucas Stach <dev@lynxeye.de>]

Hi Joshua,

Am Dienstag, den 12.01.2016, 08:05 -0800 schrieb Joshua Clayton:
> Sharp LQ101K1LY04 is a 10 inch WXGA (1280x800) lvds panel
> 

> ---
>  drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++

Missing documentation for the DT binding.

>  1 file changed, 26 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c
> b/drivers/gpu/drm/panel/panel-simple.c
> index f97b73e..9207b5d 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -708,6 +708,29 @@ static const struct panel_desc
> giantplus_gpg482739qs5 = {
>  	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
>  };
>  
> +static const struct display_timing sharp_lq101k1ly04_timing = {
> +	.pixelclock = { 60000000, 65000000, 80000000 },
> +	.hactive = { 1280, 1280, 1280 },
> +	.hfront_porch = { 20, 20, 20 },
> +	.hback_porch = { 20, 20, 20 },
> +	.hsync_len = { 10, 10, 10 },
> +	.vactive = { 800, 800, 800 },
> +	.vfront_porch = { 4, 4, 4 },
> +	.vback_porch = { 4, 4, 4 },
> +	.vsync_len = { 4, 4, 4 },
> +	.flags = DISPLAY_FLAGS_PIXDATA_POSEDGE,
> +};
> +static const struct panel_desc sharp_lq101k1ly04 = {
> +	.timings = &sharp_lq101k1ly04_timing,
> +	.num_timings = 1,
> +	.bpc = 8,
> +	.size = {
> +		.width = 217,
> +		.height = 136,
> +	},
> +	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA,
> +};
> +
This hunk isn't added at the correct place. Please keep the
alphabetical sorting.

>  static const struct display_timing hannstar_hsd070pww1_timing = {
>  	.pixelclock = { 64300000, 71100000, 82000000 },
>  	.hactive = { 1280, 1280, 1280 },
> @@ -1146,6 +1169,9 @@ static const struct of_device_id
> platform_of_match[] = {
>  		.compatible = "hannstar,hsd070pww1",
>  		.data = &hannstar_hsd070pww1,
>  	}, {
> +		.compatible = "sharp,lq101k1ly04",
> +		.data = &sharp_lq101k1ly04,
> +	}, {

Wrong insertion place again.

>  		.compatible = "hannstar,hsd100pxn1",
>  		.data = &hannstar_hsd100pxn1,
>  	}, {