From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763245AbcALSzy (ORCPT ); Tue, 12 Jan 2016 13:55:54 -0500 Received: from ns.lynxeye.de ([87.118.118.114]:42173 "EHLO lynxeye.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1762816AbcALSzx (ORCPT ); Tue, 12 Jan 2016 13:55:53 -0500 X-Greylist: delayed 619 seconds by postgrey-1.27 at vger.kernel.org; Tue, 12 Jan 2016 13:55:52 EST Message-ID: <1452624330.2628.3.camel@lynxeye.de> Subject: Re: [PATCH] drm/panel: simple: Add support for Sharp LQ101K1LY04 From: Lucas Stach To: Joshua Clayton , Thierry Reding , David Airlie Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Date: Tue, 12 Jan 2016 19:45:30 +0100 In-Reply-To: <1452614746-7841-1-git-send-email-stillcompiling@gmail.com> References: <1452614746-7841-1-git-send-email-stillcompiling@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.3 (3.18.3-1.fc23) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Joshua, Am Dienstag, den 12.01.2016, 08:05 -0800 schrieb Joshua Clayton: > Sharp LQ101K1LY04 is a 10 inch WXGA (1280x800) lvds panel > > --- >  drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++ Missing documentation for the DT binding. >  1 file changed, 26 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c > b/drivers/gpu/drm/panel/panel-simple.c > index f97b73e..9207b5d 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -708,6 +708,29 @@ static const struct panel_desc > giantplus_gpg482739qs5 = { >   .bus_format = MEDIA_BUS_FMT_RGB888_1X24, >  }; >   > +static const struct display_timing sharp_lq101k1ly04_timing = { > + .pixelclock = { 60000000, 65000000, 80000000 }, > + .hactive = { 1280, 1280, 1280 }, > + .hfront_porch = { 20, 20, 20 }, > + .hback_porch = { 20, 20, 20 }, > + .hsync_len = { 10, 10, 10 }, > + .vactive = { 800, 800, 800 }, > + .vfront_porch = { 4, 4, 4 }, > + .vback_porch = { 4, 4, 4 }, > + .vsync_len = { 4, 4, 4 }, > + .flags = DISPLAY_FLAGS_PIXDATA_POSEDGE, > +}; > +static const struct panel_desc sharp_lq101k1ly04 = { > + .timings = &sharp_lq101k1ly04_timing, > + .num_timings = 1, > + .bpc = 8, > + .size = { > + .width = 217, > + .height = 136, > + }, > + .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA, > +}; > + This hunk isn't added at the correct place. Please keep the alphabetical sorting. >  static const struct display_timing hannstar_hsd070pww1_timing = { >   .pixelclock = { 64300000, 71100000, 82000000 }, >   .hactive = { 1280, 1280, 1280 }, > @@ -1146,6 +1169,9 @@ static const struct of_device_id > platform_of_match[] = { >   .compatible = "hannstar,hsd070pww1", >   .data = &hannstar_hsd070pww1, >   }, { > + .compatible = "sharp,lq101k1ly04", > + .data = &sharp_lq101k1ly04, > + }, { Wrong insertion place again. >   .compatible = "hannstar,hsd100pxn1", >   .data = &hannstar_hsd100pxn1, >   }, {