From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754739AbcAMFoQ (ORCPT ); Wed, 13 Jan 2016 00:44:16 -0500 Received: from smtprelay0160.hostedemail.com ([216.40.44.160]:55109 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751270AbcAMFoO (ORCPT ); Wed, 13 Jan 2016 00:44:14 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 20,1.5,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1543:1593:1594:1605:1711:1730:1747:1777:1792:2198:2199:2393:2553:2559:2562:2693:2828:2899:2903:3138:3139:3140:3141:3142:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4321:5007:6117:6119:6261:7903:9010:10009:10400:10848:11026:11232:11473:11658:11783:11914:12043:12048:12438:12517:12519:12555:12740:13095:13894:14096:14097:14659:21060:21080:30030:30041:30054:30060:30083:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:2:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: wood03_7bfd4c3548244 X-Filterd-Recvd-Size: 4648 Message-ID: <1452663850.8586.3.camel@perches.com> Subject: Re: [PATCH -next] tty/serial: atmel: Include module.h to fix build failure From: Joe Perches To: Guenter Roeck , Paul Gortmaker , Sudip Mukherjee , postmaster Cc: Greg Kroah-Hartman , Nicolas Ferre , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 12 Jan 2016 21:44:10 -0800 In-Reply-To: <5695E207.9080309@roeck-us.net> References: <1452363335-2535-1-git-send-email-linux@roeck-us.net> <20160109182908.GB29967@kroah.com> <20160111083536.GB8070@sudip-pc> <20160111111101.GA18945@roeck-us.net> <5693C553.7050400@windriver.com> <5695E207.9080309@roeck-us.net> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.3-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-01-12 at 21:35 -0800, Guenter Roeck wrote: > On 01/11/2016 07:08 AM, Paul Gortmaker wrote: > > On 2016-01-11 06:11 AM, Guenter Roeck wrote: > > > On Mon, Jan 11, 2016 at 02:05:36PM +0530, Sudip Mukherjee wrote: > > > > On Sat, Jan 09, 2016 at 10:29:08AM -0800, Greg Kroah-Hartman wrote: > > > > > On Sat, Jan 09, 2016 at 10:15:35AM -0800, Guenter Roeck wrote: > > > > > > If serial/atmel_serial.c is compiled with devicetree enabled, the > > > > > > following build error is observed. > > > > > > > > > > > > drivers/tty/serial/atmel_serial.c:192:1: warning: > > > > > > data definition has no type or storage class > > > > > > drivers/tty/serial/atmel_serial.c:192:1: error: > > > > > > type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' > > > > > > drivers/tty/serial/atmel_serial.c:192:1: warning: > > > > > > parameter names (without types) in function declaration > > > > > > > > > > > > MODULE_DEVICE_TABLE is used to specify devicetree compatibilities. > > > > > > > > > > > > Fixes: c39dfebc7798 ("drivers/tty/serial: make serial/atmel_serial.c explicitly non-modular") > > > > > > Cc: Paul Gortmaker > > > > > > Signed-off-by: Guenter Roeck > > > > > > --- > > > > > >   drivers/tty/serial/atmel_serial.c | 1 + > > > > > >   1 file changed, 1 insertion(+) > > > > > > > > > > This hit my tree last night already with commit > > > > > 041497eb721ddbdc1e690316976dd8ba7bc136a2, so all should be fine in the > > > > > next linux-next release. > > > > > > > > Hi Guenter, > > > > Just a thought. It has happended many times that we both have sent > > > > patches to fix the same build fail. Maybe your patch got applied and > > > > mine came late or maybe mine was applied and you came late. But I think > > > > if we have a separate mailing list where people interested to fix and > > > > monitor build failures will be members and we Cc that list whenever we > > > > send patch for build fail and then in that case we will know that > > > > someone else has already sent a patch for this failure and we can invest > > > > the time in some other problem. > > > > > > > > > > Hi Sudip, > > > > > > I agree, it would make sense to have a build(/runtime?)-fixes-only mailing > > > list. Question though is how to limit noise on such a list and, of course, > > > where and how to set it up. Any thoughts ? > > > > Since most (all?) of these kind of fails are on linux-next, why not > > Most or many, but not all. > > > do what everyone else does, and report the fail there and/or ensure > > the fix is cc'd there?   Before I waste time trying to fix sth on > > linux-next, I always google for the error msg and many times that > > leads me to a lkml or linux-next post where it was reported and > > fixed already. > > Many times, Sudip and I end up fixing problems literally in parallel, > and it happened quite often lately that we do send patches in parallel. > Even if I do a Google search for an error message, it happens quite > often that I get no results, yet the fix is already out there on > some list. > > Sudip, one option would be to set up a semi-private mailing list. > My build tests now have a dedicated virtual host (kerneltests.org). > I could set up a managed list there. Perhaps it'd be better to have something like linux-build-failures@vger.kernel.org