From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755417AbcAMHVt (ORCPT ); Wed, 13 Jan 2016 02:21:49 -0500 Received: from devils.ext.ti.com ([198.47.26.153]:34879 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755173AbcAMHVr (ORCPT ); Wed, 13 Jan 2016 02:21:47 -0500 From: Milo Kim To: CC: , Milo Kim , Jason Cooper , Marc Zyngier , Ludovic Desroches , Nicholas Ferre , Subject: [PATCH 4/4] irqchip: atmel-aic: Remove duplicate bit operation Date: Wed, 13 Jan 2016 16:19:52 +0900 Message-ID: <1452669592-3401-4-git-send-email-milo.kim@ti.com> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1452669592-3401-1-git-send-email-milo.kim@ti.com> References: <1452669592-3401-1-git-send-email-milo.kim@ti.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org AIC5 priority value is updated twice - in aic_common_set_priority() and when updating AT91_AIC5_SMR. Variable, 'smr' has updated priority value (intspec[2]) in the first step, so no need to update it again in the second step. Signed-off-by: Milo Kim Cc: Thomas Gleixner Cc: Jason Cooper Cc: Marc Zyngier Cc: Boris Brezillon Cc: Ludovic Desroches Cc: Nicholas Ferre Cc: linux-kernel@vger.kernel.org --- drivers/irqchip/irq-atmel-aic5.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-atmel-aic5.c b/drivers/irqchip/irq-atmel-aic5.c index f36f426..4f0d068 100644 --- a/drivers/irqchip/irq-atmel-aic5.c +++ b/drivers/irqchip/irq-atmel-aic5.c @@ -273,7 +273,7 @@ static int aic5_irq_domain_xlate(struct irq_domain *d, irq_reg_writel(bgc, *out_hwirq, AT91_AIC5_SSR); smr = irq_reg_readl(bgc, AT91_AIC5_SMR); aic_common_set_priority(intspec[2], &smr); - irq_reg_writel(bgc, intspec[2] | smr, AT91_AIC5_SMR); + irq_reg_writel(bgc, smr, AT91_AIC5_SMR); irq_gc_unlock(bgc); return ret; -- 2.7.0