From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753138AbcANUXE (ORCPT ); Thu, 14 Jan 2016 15:23:04 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:42744 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751073AbcANUXC convert rfc822-to-8bit (ORCPT ); Thu, 14 Jan 2016 15:23:02 -0500 Message-ID: <1452802977.30596.46.camel@collabora.co.uk> Subject: Re: [PATCH] net: phy: turn carrier off on phy attach From: Sjoerd Simons To: Florian Fainelli , netdev@vger.kernel.org, Andrew Lunn Cc: linux-kernel@vger.kernel.org Date: Thu, 14 Jan 2016 21:22:57 +0100 In-Reply-To: <10DF45FB-A812-4D6F-8B45-817B86FD48CE@gmail.com> References: <1452365045-5364-1-git-send-email-sjoerd.simons@collabora.co.uk> <10DF45FB-A812-4D6F-8B45-817B86FD48CE@gmail.com> Organization: Collabora Ltd. Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Mailer: Evolution 3.18.3-1 Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-01-12 at 17:31 -0800, Florian Fainelli wrote: > On January 9, 2016 10:44:05 AM PST, Sjoerd Simons abora.co.uk> wrote: > > The operstate of a networking device initially IF_OPER_UNKNOWN aka > > "unknown", updated on carrier state changes (with carrier state > > being > > on > > by default). This means it will stay unknown unless the carrier > > state > > goes to off at some point, which is not the case if the phy is > > already > > up/connected at startup. > > Correct, drivers typically call netif_carrier_off prior to > registering the network device to give a predictable link state, > regardless of whether or not they use PHYLIB. > > > > > Explicitly turn off the carrier on phy attach, leaving the phy > > state > > machine to turn the carrier on when it has done the initial > > negotiation. > > Same comment as Andrew on the comment below. > > Out of curiosity, was there a particular driver you ran into issues > with? Prepping a v2. This came up on Rada Rock2 board, so the (Rockchip) DWMAC driver combined with a realtek phy (RTL8211E). Thanks for the review -- Sjoerd Simons Collabora Ltd.