From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755490AbcAOPCQ (ORCPT ); Fri, 15 Jan 2016 10:02:16 -0500 Received: from mail-yk0-f171.google.com ([209.85.160.171]:35765 "EHLO mail-yk0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754177AbcAOO4O (ORCPT ); Fri, 15 Jan 2016 09:56:14 -0500 From: Gustavo Padovan To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, dri-devel@lists.freedesktop.org, daniels@collabora.com, =?UTF-8?q?Arve=20Hj=C3=B8nnev=C3=A5g?= , Riley Andrews , Daniel Vetter , Rob Clark , Greg Hackmann , John Harrison , Maarten Lankhorst , Gustavo Padovan Subject: [RFC 08/29] staging/android: Remove WARN_ON_ONCE when releasing sync_fence Date: Fri, 15 Jan 2016 12:55:18 -0200 Message-Id: <1452869739-3304-9-git-send-email-gustavo@padovan.org> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1452869739-3304-1-git-send-email-gustavo@padovan.org> References: <1452869739-3304-1-git-send-email-gustavo@padovan.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Gustavo Padovan There isn't any problem on removing the sync_pts from the active_list when the fence is released. If the user decides to close the fence before it is signaled we should do it and not warn about anything. Signed-off-by: Gustavo Padovan --- drivers/staging/android/sync.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/android/sync.c b/drivers/staging/android/sync.c index 5028847..273aa4b 100644 --- a/drivers/staging/android/sync.c +++ b/drivers/staging/android/sync.c @@ -432,8 +432,9 @@ static void sync_fence_release(struct fence *fence) spin_lock_irqsave(fence->lock, flags); list_del(&pt->child_list); - if (WARN_ON_ONCE(!list_empty(&pt->active_list))) + if (!list_empty(&pt->active_list)) list_del(&pt->active_list); + spin_unlock_irqrestore(fence->lock, flags); sync_timeline_put(parent); -- 2.5.0