From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932325AbcARJ3I (ORCPT ); Mon, 18 Jan 2016 04:29:08 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44303 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932110AbcARJYt (ORCPT ); Mon, 18 Jan 2016 04:24:49 -0500 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: lkml , David Ahern , Ingo Molnar , Namhyung Kim , Peter Zijlstra Subject: [PATCH 10/26] perf tools: Remove perf_hpp__column_(disable|enable) Date: Mon, 18 Jan 2016 10:24:08 +0100 Message-Id: <1453109064-1026-11-git-send-email-jolsa@kernel.org> In-Reply-To: <1453109064-1026-1-git-send-email-jolsa@kernel.org> References: <1453109064-1026-1-git-send-email-jolsa@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Those functions are no longer needed. They operate over perf_hpp__format array which is now used only as template for dynamic entries. Link: http://lkml.kernel.org/n/tip-k893o732njrt4hiiz7jplwwp@git.kernel.org Signed-off-by: Jiri Olsa --- tools/perf/ui/hist.c | 12 ------------ tools/perf/util/hist.h | 2 -- 2 files changed, 14 deletions(-) diff --git a/tools/perf/ui/hist.c b/tools/perf/ui/hist.c index c877c52ff4bc..80d63a997287 100644 --- a/tools/perf/ui/hist.c +++ b/tools/perf/ui/hist.c @@ -519,18 +519,6 @@ void perf_hpp__register_sort_field(struct perf_hpp_fmt *format) list_add_tail(&format->sort_list, &perf_hpp__sort_list); } -void perf_hpp__column_enable(unsigned col) -{ - BUG_ON(col >= PERF_HPP__MAX_INDEX); - perf_hpp__column_register(&perf_hpp__format[col]); -} - -void perf_hpp__column_disable(unsigned col) -{ - BUG_ON(col >= PERF_HPP__MAX_INDEX); - perf_hpp__column_unregister(&perf_hpp__format[col]); -} - void perf_hpp__cancel_cumulate(void) { struct perf_hpp_fmt *fmt, *acc, *ovh, *tmp; diff --git a/tools/perf/util/hist.h b/tools/perf/util/hist.h index 9a240d7b8d3b..1f9e21dd53f3 100644 --- a/tools/perf/util/hist.h +++ b/tools/perf/util/hist.h @@ -259,8 +259,6 @@ enum { void perf_hpp__init(void); void perf_hpp__column_register(struct perf_hpp_fmt *format); void perf_hpp__column_unregister(struct perf_hpp_fmt *format); -void perf_hpp__column_enable(unsigned col); -void perf_hpp__column_disable(unsigned col); void perf_hpp__cancel_cumulate(void); void perf_hpp__register_sort_field(struct perf_hpp_fmt *format); -- 2.4.3