From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757067AbcASCaH (ORCPT <rfc822;w@1wt.eu>);
	Mon, 18 Jan 2016 21:30:07 -0500
Received: from mail-wm0-f50.google.com ([74.125.82.50]:36657 "EHLO
	mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756744AbcASCaF (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 18 Jan 2016 21:30:05 -0500
Message-ID: <1453170597.3740.7.camel@gmail.com>
Subject: Re: [rfc patch v4.4-rt2] sched: fix up preempt lazy forward port
From: Mike Galbraith <umgwanakikbuti@gmail.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Thomas Gleixner <tglx@linutronix.de>, LKML <linux-kernel@vger.kernel.org>,
        linux-rt-users <linux-rt-users@vger.kernel.org>
Date: Tue, 19 Jan 2016 03:29:57 +0100
In-Reply-To: <20160118201828.GE12309@linutronix.de>
References: <1453108103.4123.4.camel@gmail.com>
	 <20160118201828.GE12309@linutronix.de>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.16.5 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 2016-01-18 at 21:18 +0100, Sebastian Andrzej Siewior wrote:

> > --- a/kernel/sched/core.c
> > +++ b/kernel/sched/core.c
> > @@ -3542,6 +3542,15 @@ asmlinkage __visible void __sched notrac
> > 	if (likely(!preemptible()))
> > 		return;
> > 
> > +#ifdef CONFIG_PREEMPT_LAZY
> > +	/*
> > +	 * Check for lazy preemption
> > +	 */
> > +	if (current_thread_info()->preempt_lazy_count &&
> > +	    !test_thread_flag(TIF_NEED_RESCHED))
> > +		return;
> > +#endif
> > +
> 
> And this is a new piece. So you forbid that tasks leave the CPU if
> lazy_count > 0. Let me look closed why this is happening and if this is
> v4.1 … v4.4 or not.

We should probably just add the lazy bits to preemptible().

	-Mike