From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754533AbcASNVS (ORCPT ); Tue, 19 Jan 2016 08:21:18 -0500 Received: from mga14.intel.com ([192.55.52.115]:14999 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753895AbcASNVD (ORCPT ); Tue, 19 Jan 2016 08:21:03 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,317,1449561600"; d="scan'208";a="863778331" Message-ID: <1453209684.2521.115.camel@linux.intel.com> Subject: Re: [PATCH 0/3] 8250: Split Fintek PCIE to UART to independent file From: Andy Shevchenko To: One Thousand Gnomes , Peter Hung Cc: Paul Gortmaker , gregkh@linuxfoundation.org, jslaby@suse.com, heikki.krogerus@linux.intel.com, peter@hurleysoftware.com, soeren.grunewald@desy.de, udknight@gmail.com, adam.lee@canonical.com, arnd@arndb.de, yamada.masahiro@socionext.com, mans@mansr.com, scottwood@freescale.com, paul.burton@imgtec.com, matthias.bgg@gmail.com, manabian@gmail.com, peter.ujfalusi@ti.com, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, peter_hong@fintek.com.tw, Peter Hung Date: Tue, 19 Jan 2016 15:21:24 +0200 In-Reply-To: <20160119123327.3b519062@lxorguk.ukuu.org.uk> References: <1453171266-15874-1-git-send-email-hpeter+linux_kernel@gmail.com> <20160119035649.GA1696@windriver.com> <569DF7C3.5050306@gmail.com> <20160119123327.3b519062@lxorguk.ukuu.org.uk> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-01-19 at 12:33 +0000, One Thousand Gnomes wrote: > > The architecture of 8250_pci.c is good for PCIE device with 8250 > > compatible serial ports. We want to implement all functions of > > F81504/508/512, but it'll make 8250_pci.c bloated and complex if we > > implement GPIOLIB in 8250_pci.c > > Your device is multi-function. Create an MFD driver for it. Make the > 8250 driver bind to the MFD, and provide your own baud rate methods > within the standard 8250 layer Ouch, somehow I missed this one! Peter, Alan's suggestion is really worth to try. > > Implement the GPIO lines in a GPIO driver that also binds to the MFD > and > lives in drivers/gpio > > All the needed pieces already exist to implement it cleanly this way > without duplicating a ton of code. > > Alan -- Andy Shevchenko Intel Finland Oy