From: Jiri Olsa <jolsa@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: stable@vger.kernel.org.#.v4.2+,
Mel Gorman <mgorman@techsingularity.net>,
lkml <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>, Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: [PATCH 3/4] perf stat: Do not clean event's private stats
Date: Wed, 20 Jan 2016 12:56:34 +0100 [thread overview]
Message-ID: <1453290995-18485-4-git-send-email-jolsa@kernel.org> (raw)
In-Reply-To: <1453290995-18485-1-git-send-email-jolsa@kernel.org>
Mel reported stddev reporting was broken due to
following commit:
106a94a0f8c2 perf stat: Introduce read_counters function
This commit merged interval and overall counters
reading into single read_counters function.
The old interval code cleaned the stddev data for
some reason (it's never displayed in interval mode)
and the mentioned commit kept on cleaning the stddev
data in merged function, which resulted in the stddev
not being displayed.
Removing the wrong stddev data cleanup init_stats call.
Reported-by: Mel Gorman <mgorman@techsingularity.net>
Tested-by: Mel Gorman <mgorman@techsingularity.net>
Cc: stable@vger.kernel.org # v4.2+
Cc: Mel Gorman <mgorman@techsingularity.net>
Link: http://lkml.kernel.org/n/tip-tbcxtpjsqrrbwn2me0je8yxt@git.kernel.org
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
tools/perf/util/stat.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/perf/util/stat.c b/tools/perf/util/stat.c
index 2f901d15e063..2b58edccd56f 100644
--- a/tools/perf/util/stat.c
+++ b/tools/perf/util/stat.c
@@ -310,7 +310,6 @@ int perf_stat_process_counter(struct perf_stat_config *config,
int i, ret;
aggr->val = aggr->ena = aggr->run = 0;
- init_stats(ps->res_stats);
if (counter->per_pkg)
zero_per_pkg(counter);
--
2.4.3
next prev parent reply other threads:[~2016-01-20 11:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 11:56 [PATCH 0/4] perf tools: Fixes Jiri Olsa
2016-01-20 11:56 ` [PATCH 1/4] perf tools: Do not read symbols/data from device files Jiri Olsa
2016-02-03 10:06 ` [tip:perf/core] perf symbols: Do not read symbols/ data " tip-bot for Jiri Olsa
2016-01-20 11:56 ` [PATCH 2/4] perf tools: Fix HISTC_MEM_DCACHELINE width setting Jiri Olsa
2016-01-30 8:25 ` [tip:perf/urgent] perf hists: " tip-bot for Jiri Olsa
2016-01-20 11:56 ` Jiri Olsa [this message]
2016-01-30 8:25 ` [tip:perf/urgent] perf stat: Do not clean event's private stats tip-bot for Jiri Olsa
2016-01-20 11:56 ` [PATCH 4/4] perf stat: Making several helper functions static Jiri Olsa
2016-02-03 10:07 ` [tip:perf/core] " tip-bot for Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453290995-18485-4-git-send-email-jolsa@kernel.org \
--to=jolsa@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=dsahern@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@techsingularity.net \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=stable@vger.kernel.org.#.v4.2+ \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).