From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933445AbcATL4u (ORCPT ); Wed, 20 Jan 2016 06:56:50 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46937 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932558AbcATL4q (ORCPT ); Wed, 20 Jan 2016 06:56:46 -0500 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: stable@vger.kernel.org.#.v4.2+, Mel Gorman , lkml , David Ahern , Ingo Molnar , Namhyung Kim , Peter Zijlstra Subject: [PATCH 3/4] perf stat: Do not clean event's private stats Date: Wed, 20 Jan 2016 12:56:34 +0100 Message-Id: <1453290995-18485-4-git-send-email-jolsa@kernel.org> In-Reply-To: <1453290995-18485-1-git-send-email-jolsa@kernel.org> References: <1453290995-18485-1-git-send-email-jolsa@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mel reported stddev reporting was broken due to following commit: 106a94a0f8c2 perf stat: Introduce read_counters function This commit merged interval and overall counters reading into single read_counters function. The old interval code cleaned the stddev data for some reason (it's never displayed in interval mode) and the mentioned commit kept on cleaning the stddev data in merged function, which resulted in the stddev not being displayed. Removing the wrong stddev data cleanup init_stats call. Reported-by: Mel Gorman Tested-by: Mel Gorman Cc: stable@vger.kernel.org # v4.2+ Cc: Mel Gorman Link: http://lkml.kernel.org/n/tip-tbcxtpjsqrrbwn2me0je8yxt@git.kernel.org Signed-off-by: Jiri Olsa --- tools/perf/util/stat.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/perf/util/stat.c b/tools/perf/util/stat.c index 2f901d15e063..2b58edccd56f 100644 --- a/tools/perf/util/stat.c +++ b/tools/perf/util/stat.c @@ -310,7 +310,6 @@ int perf_stat_process_counter(struct perf_stat_config *config, int i, ret; aggr->val = aggr->ena = aggr->run = 0; - init_stats(ps->res_stats); if (counter->per_pkg) zero_per_pkg(counter); -- 2.4.3