From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758747AbcAUFWf (ORCPT <rfc822;w@1wt.eu>);
	Thu, 21 Jan 2016 00:22:35 -0500
Received: from mailgw02.mediatek.com ([210.61.82.184]:39837 "EHLO
	mailgw02.hq.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL)
	by vger.kernel.org with ESMTP id S1751491AbcAUFWb (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 21 Jan 2016 00:22:31 -0500
Message-ID: <1453353746.5384.35.camel@mtksdaap41>
Subject: Re: [PATCH v4 3/4] soc: mediatek: Add MT2701 power dt-bindings
From: James Liao <jamesjj.liao@mediatek.com>
To: Rob Herring <robh@kernel.org>, Yingjoe Chen <yingjoe.chen@mediatek.com>
CC: Matthias Brugger <matthias.bgg@gmail.com>,
        Sascha Hauer <kernel@pengutronix.de>, <srv_heupstream@mediatek.com>,
        <devicetree@vger.kernel.org>, Kevin Hilman <khilman@kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-mediatek@lists.infradead.org>,
        "Shunli Wang" <shunli.wang@mediatek.com>,
        <linux-arm-kernel@lists.infradead.org>
Date: Thu, 21 Jan 2016 13:22:26 +0800
In-Reply-To: <20160120163502.GA22147@rob-hp-laptop>
References: <1453270097-53853-1-git-send-email-jamesjj.liao@mediatek.com>
	 <1453270097-53853-4-git-send-email-jamesjj.liao@mediatek.com>
	 <1453282161.16515.9.camel@mtksdaap41>
	 <20160120163502.GA22147@rob-hp-laptop>
Content-Type: text/plain; charset="us-ascii"
X-Mailer: Evolution 3.2.3-0ubuntu6 
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MTK: N
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Yingjoe, Rob,

On Wed, 2016-01-20 at 10:35 -0600, Rob Herring wrote:
> On Wed, Jan 20, 2016 at 05:29:21PM +0800, Yingjoe Chen wrote:
> > On Wed, 2016-01-20 at 14:08 +0800, James Liao wrote:
> > > From: Shunli Wang <shunli.wang@mediatek.com>
> > > 
> > > Add power dt-bindings for MT2701.
> > > 
> > > Signed-off-by: Shunli Wang <shunli.wang@mediatek.com>
> > > Signed-off-by: James Liao <jamesjj.liao@mediatek.com>
> > > ---
> > >  .../devicetree/bindings/soc/mediatek/scpsys.txt    |  6 +++--
> > >  include/dt-bindings/power/mt2701-power.h           | 27 ++++++++++++++++++++++
> > >  2 files changed, 31 insertions(+), 2 deletions(-)
> > >  create mode 100644 include/dt-bindings/power/mt2701-power.h
> > > 
> > > diff --git a/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt b/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt
> > > index a6c8afc..807d87f 100644
> > > --- a/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt
> > > +++ b/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt
> > > @@ -9,10 +9,12 @@ domain control.
> > >  
> > >  The driver implements the Generic PM domain bindings described in
> > >  power/power_domain.txt. It provides the power domains defined in
> > > -include/dt-bindings/power/mt8173-power.h.
> > > +include/dt-bindings/power/mt8173-power.h and mt2701-power.h.
> > >  
> > >  Required properties:
> > > -- compatible: Must be "mediatek,mt8173-scpsys"
> > > +- compatible: Should be:
> > > +	- "mediatek,mt8173-scpsys"
> > > +	- "mediatek,mt2701-scpsys"
> > >  - #power-domain-cells: Must be 1
> > >  - reg: Address range of the SCPSYS unit
> > >  - infracfg: must contain a phandle to the infracfg controller
> > 
> > Please sort the list.
> 
> And s/Should be/Should be one of/

OK. I'll modify it in next patch.


Best regards,

James