From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S964978AbcAUFtr (ORCPT <rfc822;w@1wt.eu>);
	Thu, 21 Jan 2016 00:49:47 -0500
Received: from mailgw01.mediatek.com ([210.61.82.183]:21898 "EHLO
	mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org
	with ESMTP id S1750751AbcAUFtn (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 21 Jan 2016 00:49:43 -0500
Message-ID: <1453355375.5384.41.camel@mtksdaap41>
Subject: Re: [PATCH v3 1/6] clk: mediatek: Refine the makefile to support
 multiple clock drivers
From: James Liao <jamesjj.liao@mediatek.com>
To: Yingjoe Chen <yingjoe.chen@mediatek.com>
CC: Matthias Brugger <matthias.bgg@gmail.com>,
        Mike Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@codeaurora.org>,
        "John Crispin" <blogic@openwrt.org>, <devicetree@vger.kernel.org>,
        Sascha Hauer <kernel@pengutronix.de>, <srv_heupstream@mediatek.com>,
        <linux-kernel@vger.kernel.org>, <linux-mediatek@lists.infradead.org>,
        "Shunli Wang" <shunli.wang@mediatek.com>,
        Philipp Zabel <p.zabel@pengutronix.de>, <linux-clk@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>
Date: Thu, 21 Jan 2016 13:49:35 +0800
In-Reply-To: <1453343300.28078.6.camel@mtksdaap41>
References: <1452587470-61506-1-git-send-email-jamesjj.liao@mediatek.com>
	 <1452587470-61506-2-git-send-email-jamesjj.liao@mediatek.com>
	 <1453343300.28078.6.camel@mtksdaap41>
Content-Type: text/plain; charset="us-ascii"
X-Mailer: Evolution 3.2.3-0ubuntu6 
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MTK: N
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Yingjoe,

On Thu, 2016-01-21 at 10:28 +0800, Yingjoe Chen wrote:
> On Tue, 2016-01-12 at 16:31 +0800, James Liao wrote:
> > Add a Kconfig to define clock configuration for each SoC, and
> > modify the Makefile to build drivers that only selected in config.
> > 
> > Signed-off-by: Shunli Wang <shunli.wang@mediatek.com>
> > Signed-off-by: James Liao <jamesjj.liao@mediatek.com>
> > ---
> >  drivers/clk/Kconfig           |  1 +
> >  drivers/clk/mediatek/Kconfig  | 23 +++++++++++++++++++++++
> >  drivers/clk/mediatek/Makefile |  6 +++---
> >  3 files changed, 27 insertions(+), 3 deletions(-)
> >  create mode 100644 drivers/clk/mediatek/Kconfig
> > 
> > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
> > index c3e3a02..b7a37dc 100644
> > --- a/drivers/clk/Kconfig
> > +++ b/drivers/clk/Kconfig
> > @@ -198,3 +198,4 @@ source "drivers/clk/mvebu/Kconfig"
> >  
> >  source "drivers/clk/samsung/Kconfig"
> >  source "drivers/clk/tegra/Kconfig"
> > +source "drivers/clk/mediatek/Kconfig"
> 
> 
> Hi James,
> 
> drivers/clk/mediatek/Kconfig add user selectable options, menuconfig
> will list them outside of "Common Clock Framework" sub-menu if you
> source the file here. Kconfig for samsung & tegra doesn't have any, so
> it is OK for them to stay here.
> 
> Please move it inside the menu, also it seems the source lines are
> sorted now, so let's keep them sorted.

OK. I'll move mediatek/Kconfig into menu section in next patch.


Best regards,

James