From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753358AbcAVL6F (ORCPT <rfc822;w@1wt.eu>);
	Fri, 22 Jan 2016 06:58:05 -0500
Received: from e23smtp04.au.ibm.com ([202.81.31.146]:39462 "EHLO
	e23smtp04.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752733AbcAVL54 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 22 Jan 2016 06:57:56 -0500
X-IBM-Helo: d23dlp01.au.ibm.com
X-IBM-MailFrom: zohar@linux.vnet.ibm.com
X-IBM-RcptTo: linux-kernel@vger.kernel.org;linux-security-module@vger.kernel.org
Message-ID: <1453463812.9549.202.camel@linux.vnet.ibm.com>
Subject: Re: [PATCH v3 3/5] firmware: fold successful fw read early
From: Mimi Zohar <zohar@linux.vnet.ibm.com>
To: "Luis R. Rodriguez" <mcgrof@suse.com>
Cc: Josh Boyer <jwboyer@fedoraproject.org>,
        "Luis R. Rodriguez" <mcgrof@do-not-panic.com>,
        Greg KH <gregkh@linuxfoundation.org>,
        Ming Lei <ming.lei@canonical.com>,
        Johannes Berg <johannes@sipsolutions.net>,
        Andy Lutomirski <luto@amacapital.net>,
        Jonathan Corbet <corbet@lwn.net>,
        David Woodhouse <dwmw2@infradead.org>,
        David Howells <dhowells@redhat.com>,
        Seth Forshee <seth.forshee@canonical.com>,
        Rusty Russell <rusty@rustcorp.com.au>, Michal Marek <mmarek@suse.cz>,
        Matthew Garrett <mjg59@srcf.ucam.org>, kyle@kernel.org,
        dmitry.kasatkin@gmail.com, Vivek Goyal <vgoyal@redhat.com>,
        Brian Norris <computersforpeace@gmail.com>,
        Kees Cook <keescook@chromium.org>, shuahkh@osg.samsung.com,
        Linus Torvalds <torvalds@linux-foundation.org>,
        linux-security-module <linux-security-module@vger.kernel.org>,
        keyrings@linux-nfs.org,
        "Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>
Date: Fri, 22 Jan 2016 06:56:52 -0500
In-Reply-To: <20160122014541.GV20964@wotan.suse.de>
References: <1450906497-24179-1-git-send-email-mcgrof@do-not-panic.com>
	 <1450906497-24179-4-git-send-email-mcgrof@do-not-panic.com>
	 <CA+5PVA6O_rhHF2d+4iNjwNCQWz7F5-EwJUBjaM4-XdRYDMxXmw@mail.gmail.com>
	 <20160122014541.GV20964@wotan.suse.de>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.12.11 (3.12.11-1.fc21) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-TM-AS-MML: disable
X-Content-Scanned: Fidelis XPS MAILER
x-cbid: 16012211-0013-0000-0000-00000297AFD1
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 2016-01-22 at 02:45 +0100, Luis R. Rodriguez wrote:
> On Mon, Jan 04, 2016 at 03:48:29PM -0500, Josh Boyer wrote:
> > On Wed, Dec 23, 2015 at 4:34 PM, Luis R. Rodriguez
> > <mcgrof@do-not-panic.com> wrote:
> > > From: David Howells <dhowells@redhat.com>
> > >
> > > We'll be folding in some more checks on fw_read_file_contents(),
> > > this will make the success case easier to follow.
> > >
> > > Signed-off-by: David Howells <dhowells@redhat.com>
> > > Signed-off-by: Luis R. Rodriguez <mcgrof@suse.com>
> > 
> > Reviewed-by: Josh Boyer <jwboyer@fedoraproject.org>
> 
> Thanks Josh.
> 
> Mimi, this is the other patch that  I was referring to.

After this patch set, replacing the fw_read_file calls with the
kernel_read_file_from_path() version is straight forward.  Nice!

Mimi