From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754769AbcAVSOs (ORCPT ); Fri, 22 Jan 2016 13:14:48 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:45937 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754582AbcAVSOq (ORCPT ); Fri, 22 Jan 2016 13:14:46 -0500 From: Guenter Roeck To: Alexander Viro Cc: linux-fsdevel@vger.kernel.org, linux-aio@kvack.org, linux-kernel@vger.kernel.org, kernel-testers@vger.kernel.org, Guenter Roeck , Benjamin LaHaise Subject: [PATCH -next] aio: Fix compile error due to unexpected use of cmpxchg() Date: Fri, 22 Jan 2016 10:14:39 -0800 Message-Id: <1453486479-19347-1-git-send-email-linux@roeck-us.net> X-Mailer: git-send-email 2.1.4 X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org cmpxchg() on some architectures (ia64) doesn't like functions as parameters. This results in the following compile error on the affected architectures. fs/aio.c: In function 'aio_thread_fn': fs/aio.c:1499:1: error: cast specifies function type Fixes: 6a81013efc40 ("aio: add support for IOCB_CMD_POLL via aio thread helper") Cc: Benjamin LaHaise Signed-off-by: Guenter Roeck --- No idea if this is the correct or an acceptable fix. If not, please consider this to be a bug report. fs/aio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/aio.c b/fs/aio.c index 56bcdf4105f4..229a91e391df 100644 --- a/fs/aio.c +++ b/fs/aio.c @@ -1495,8 +1495,8 @@ static void aio_thread_fn(struct work_struct *work) * cancellation if it has not already occurred. */ old_cancel = cmpxchg(&iocb->ki_cancel, - aio_thread_queue_iocb_cancel_early, - aio_thread_queue_iocb_cancel); + (kiocb_cancel_fn *)aio_thread_queue_iocb_cancel_early, + (kiocb_cancel_fn *)aio_thread_queue_iocb_cancel); if (old_cancel != KIOCB_CANCELLED) ret = iocb->ki_work_fn(iocb); else -- 2.1.4