From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754638AbcAXNz2 (ORCPT ); Sun, 24 Jan 2016 08:55:28 -0500 Received: from mail-pf0-f195.google.com ([209.85.192.195]:34063 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754422AbcAXNzS (ORCPT ); Sun, 24 Jan 2016 08:55:18 -0500 From: Namhyung Kim To: Arnaldo Carvalho de Melo Cc: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , Andi Kleen , David Ahern , Frederic Weisbecker , Wang Nan Subject: [PATCH 12/12] perf report: Fix callchain percent limit on --gtk Date: Sun, 24 Jan 2016 22:53:35 +0900 Message-Id: <1453643615-1616-13-git-send-email-namhyung@kernel.org> X-Mailer: git-send-email 2.6.4 In-Reply-To: <1453643615-1616-1-git-send-email-namhyung@kernel.org> References: <1453643615-1616-1-git-send-email-namhyung@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When a percent limit is given, it should take callchains into account. Signed-off-by: Namhyung Kim --- tools/perf/ui/gtk/hists.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/tools/perf/ui/gtk/hists.c b/tools/perf/ui/gtk/hists.c index 0f8dcfdfb10f..8652c3c967b9 100644 --- a/tools/perf/ui/gtk/hists.c +++ b/tools/perf/ui/gtk/hists.c @@ -100,9 +100,14 @@ static void perf_gtk__add_callchain_flat(struct rb_root *root, GtkTreeStore *sto struct callchain_list *chain; GtkTreeIter iter, new_parent; bool need_new_parent; + double percent; node = rb_entry(nd, struct callchain_node, rb_node); + percent = 100.0 * callchain_cumul_hits(node) / total; + if (percent < callchain_param.min_percent) + continue; + new_parent = *parent; need_new_parent = !has_single_node; @@ -164,9 +169,14 @@ static void perf_gtk__add_callchain_folded(struct rb_root *root, GtkTreeStore *s char buf[64]; char *str, *str_alloc = NULL; bool first = true; + double percent; node = rb_entry(nd, struct callchain_node, rb_node); + percent = 100.0 * callchain_cumul_hits(node) / total; + if (percent < callchain_param.min_percent) + continue; + callchain_node__make_parent_list(node); list_for_each_entry(chain, &node->parent_val, list) { @@ -224,9 +234,14 @@ static void perf_gtk__add_callchain_graph(struct rb_root *root, GtkTreeStore *st GtkTreeIter iter, new_parent; bool need_new_parent; u64 child_total; + double percent; node = rb_entry(nd, struct callchain_node, rb_node); + percent = 100.0 * callchain_cumul_hits(node) / total; + if (percent < callchain_param.min_percent) + continue; + new_parent = *parent; need_new_parent = !has_single_node && (node->val_nr > 1); -- 2.6.4