From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755680AbcAYIsO (ORCPT ); Mon, 25 Jan 2016 03:48:14 -0500 Received: from mga11.intel.com ([192.55.52.93]:5912 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755584AbcAYIsM (ORCPT ); Mon, 25 Jan 2016 03:48:12 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,343,1449561600"; d="scan'208";a="900512874" Message-ID: <1453711724.2521.212.camel@linux.intel.com> Subject: Re: [PATCH 11/15] dmaengine: dw: platform: use field-by-field initialization From: Andy Shevchenko To: Mans Rullgard , Viresh Kumar , Vinod Koul , linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org Cc: Dan Williams Date: Mon, 25 Jan 2016 10:48:44 +0200 In-Reply-To: <1453663322-14474-12-git-send-email-mans@mansr.com> References: <1453663322-14474-1-git-send-email-mans@mansr.com> <1453663322-14474-12-git-send-email-mans@mansr.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2016-01-24 at 19:21 +0000, Mans Rullgard wrote: > From: Andy Shevchenko > > This is a simple stylish change that allows to use less lines of > code. > > Signed-off-by: Andy Shevchenko > --- > I'm a little ambivalent on this one.  While the patch is correct as > such, > the change means that if struct dw_dma_slave gains new members in > future, > these will not be initialised.  This added fragility seems an > unnecesary > price to pay for saving one line of code. We may use   struct dw_dma_slave slave = {0}; if it makes someone happier. > --- >  drivers/dma/dw/platform.c | 19 +++++++++---------- >  1 file changed, 9 insertions(+), 10 deletions(-) > > diff --git a/drivers/dma/dw/platform.c b/drivers/dma/dw/platform.c > index 808bafdd7d48..0fd5a49311a2 100644 > --- a/drivers/dma/dw/platform.c > +++ b/drivers/dma/dw/platform.c > @@ -32,14 +32,13 @@ static struct dma_chan *dw_dma_of_xlate(struct > of_phandle_args *dma_spec, >   struct of_dma *ofdma) >  { >   struct dw_dma *dw = ofdma->of_dma_data; > - struct dw_dma_slave slave = { > - .dma_dev = dw->dma.dev, > - }; > + struct dw_dma_slave slave; >   dma_cap_mask_t cap; >   >   if (dma_spec->args_count != 3) >   return NULL; >   > + slave.dma_dev = dw->dma.dev; >   slave.src_id = dma_spec->args[0]; >   slave.dst_id = dma_spec->args[0]; >   slave.m_master = dma_spec->args[1]; > @@ -62,13 +61,13 @@ static struct dma_chan *dw_dma_of_xlate(struct > of_phandle_args *dma_spec, >  static bool dw_dma_acpi_filter(struct dma_chan *chan, void *param) >  { >   struct acpi_dma_spec *dma_spec = param; > - struct dw_dma_slave slave = { > - .dma_dev = dma_spec->dev, > - .src_id = dma_spec->slave_id, > - .dst_id = dma_spec->slave_id, > - .m_master = 1, > - .p_master = 0, > - }; > + struct dw_dma_slave slave; > + > + slave.dma_dev = dma_spec->dev; > + slave.src_id = dma_spec->slave_id; > + slave.dst_id = dma_spec->slave_id; > + slave.m_master = 1; > + slave.p_master = 0; >   >   return dw_dma_filter(chan, &slave); >  } -- Andy Shevchenko Intel Finland Oy