From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932306AbcAYLlQ (ORCPT ); Mon, 25 Jan 2016 06:41:16 -0500 Received: from mail-wm0-f41.google.com ([74.125.82.41]:38147 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932195AbcAYLlN (ORCPT ); Mon, 25 Jan 2016 06:41:13 -0500 From: Gioh Kim To: ray.huang@amd.com, lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org Cc: Gioh Kim Subject: [RFC] hwmon: (fam15h_power) Add bit masking for tdp_limit Date: Mon, 25 Jan 2016 12:41:07 +0100 Message-Id: <1453722067-6747-1-git-send-email-gi-oh.kim@profitbricks.com> X-Mailer: git-send-email 2.5.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The bits [31:29] of D18F5xE8 TDP Limit3 are reserved. I think it'd better to add masking to read ApmTdpLimit[28:16] precisely. Signed-off-by: Gioh Kim --- drivers/hwmon/fam15h_power.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwmon/fam15h_power.c b/drivers/hwmon/fam15h_power.c index f77eb97..f9647c8 100644 --- a/drivers/hwmon/fam15h_power.c +++ b/drivers/hwmon/fam15h_power.c @@ -90,7 +90,7 @@ static ssize_t show_power(struct device *dev, pci_bus_read_config_dword(f4->bus, PCI_DEVFN(PCI_SLOT(f4->devfn), 5), REG_TDP_LIMIT3, &val); - tdp_limit = val >> 16; + tdp_limit = (val >> 16) & 0x1fff; curr_pwr_watts = ((u64)(tdp_limit + data->base_tdp)) << running_avg_range; curr_pwr_watts -= running_avg_capture; -- 2.5.0