From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933134AbcAYPw6 (ORCPT ); Mon, 25 Jan 2016 10:52:58 -0500 Received: from aserp1050.oracle.com ([141.146.126.70]:34566 "EHLO aserp1050.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932861AbcAYPww (ORCPT ); Mon, 25 Jan 2016 10:52:52 -0500 X-Greylist: delayed 1636 seconds by postgrey-1.27 at vger.kernel.org; Mon, 25 Jan 2016 10:52:51 EST From: Sasha Levin To: akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, oleg@redhat.com, peterz@infradead.org, Sasha Levin Subject: [PATCH] signals: work around random wakeups in sigsuspend() Date: Mon, 25 Jan 2016 10:21:46 -0500 Message-Id: <1453735306-13519-1-git-send-email-sasha.levin@oracle.com> X-Mailer: git-send-email 2.5.0 X-Source-IP: userp1040.oracle.com [156.151.31.81] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A random wakeup can get us out of sigsuspend() without TIF_SIGPENDING being set. Avoid that by making sure we were signaled, like sys_pause() does. Signed-off-by: Sasha Levin --- kernel/signal.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/kernel/signal.c b/kernel/signal.c index 5da9180..3256c7e 100644 --- a/kernel/signal.c +++ b/kernel/signal.c @@ -3528,8 +3528,10 @@ static int sigsuspend(sigset_t *set) current->saved_sigmask = current->blocked; set_current_blocked(set); - __set_current_state(TASK_INTERRUPTIBLE); - schedule(); + while (!signal_pending(current)) { + __set_current_state(TASK_INTERRUPTIBLE); + schedule(); + } set_restore_sigmask(); return -ERESTARTNOHAND; } -- 1.7.10.4