From: Aniroop Mathur <a.mathur@samsung.com>
To: dmitry.torokhov@gmail.com
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
aniroop.mathur@gmail.com, Aniroop Mathur <a.mathur@samsung.com>
Subject: [PATCH] Input: evdev: correct handling of memory allocation failure of evdev_client
Date: Mon, 25 Jan 2016 23:20:05 +0530 [thread overview]
Message-ID: <1453744205-868-1-git-send-email-a.mathur@samsung.com> (raw)
Lets fix twice checking of memory allocation failure of evdev_client
structure when allocated successfully.
Signed-off-by: Aniroop Mathur <a.mathur@samsung.com>
---
drivers/input/evdev.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/input/evdev.c b/drivers/input/evdev.c
index e9ae3d5..102b5d9 100644
--- a/drivers/input/evdev.c
+++ b/drivers/input/evdev.c
@@ -503,10 +503,11 @@ static int evdev_open(struct inode *inode, struct file *file)
int error;
client = kzalloc(size, GFP_KERNEL | __GFP_NOWARN);
- if (!client)
+ if (!client) {
client = vzalloc(size);
- if (!client)
- return -ENOMEM;
+ if (!client)
+ return -ENOMEM;
+ }
client->bufsize = bufsize;
spin_lock_init(&client->buffer_lock);
--
2.6.2
next reply other threads:[~2016-01-25 17:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 17:50 Aniroop Mathur [this message]
2016-01-27 23:42 ` [PATCH] Input: evdev: correct handling of memory allocation failure of evdev_client Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453744205-868-1-git-send-email-a.mathur@samsung.com \
--to=a.mathur@samsung.com \
--cc=aniroop.mathur@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox