Re: [PATCH V2 4/4] mfd: mediatek: add MT6323 support to MT6397 driver

John Crispin
2016-01-25T15:36:46Z

Hi,

On 25/01/2016 13:41, Lee Jones wrote:
> Please honour the subject format of the subsystem you are contributing
> to.
>
> `git log --oneline -- $subsystem` gives you this.
>
> On Mon, 25 Jan 2016, John Crispin wrote:
>
>> Signed-off-by: John Crispin <blogic@openwrt.org>
>> ---

[...]

>> @@ -261,6 +271,15 @@ static int mt6397_probe(struct platform_device *pdev)
>> }
>>
>> switch (id & 0xff) {
>> + case MT6323_CID_CODE:
>> + mt6397->int_con[0] = MT6323_INT_CON0;
>
> This is confusing. You're still using memory allocated for a mt6397
> device.
>

the variable is currently defined as struct mt6397_chip *mt6397;
shall i only change the name or also create a patch to rename the struct ?

John