From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Matt Fleming <matt@codeblueprint.co.uk>,
"Elliott, Robert (Persistent Memory)" <elliott@hpe.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel @ vger . kernel . org"
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 3/4] x86/efi: print size in binary units in efi_print_memmap
Date: Tue, 26 Jan 2016 13:59:26 +0200 [thread overview]
Message-ID: <1453809566.2521.239.camel@linux.intel.com> (raw)
In-Reply-To: <20160126115041.GA7478@codeblueprint.co.uk>
On Tue, 2016-01-26 at 11:50 +0000, Matt Fleming wrote:
> On Mon, 25 Jan, at 08:37:58PM, Elliott, Robert (Persistent Memory)
> wrote:
> >
> > For the UEFI memory map, that was indeed my intention. I
> > don't want it silently round to "20 GiB". Even rounding
> > to "19.999 GiB" is imprecise.
>
> OK, let's just go with your original patch Robert (minus the @ addr
> bit) since it's pretty small and does what we want for this specific
> case.
However I am against this, but seems reviewers do not leave a chance to
us, I would propose to copy-and-paste table of binary prefixes and use
__ffs64().
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2016-01-26 11:58 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-23 14:55 [PATCH v3 0/4] x86/efi: use binary units when printing Andy Shevchenko
2016-01-23 14:55 ` [PATCH v3 1/4] lib/string_helpers: export string_units_{2,10} for others Andy Shevchenko
2016-01-23 16:14 ` James Bottomley
2016-01-23 16:58 ` Andy Shevchenko
2016-01-23 14:55 ` [PATCH v3 2/4] lib/string_helpers: fix indentation in few places Andy Shevchenko
2016-01-23 14:55 ` [PATCH v3 3/4] x86/efi: print size in binary units in efi_print_memmap Andy Shevchenko
2016-01-23 16:44 ` James Bottomley
2016-01-23 17:18 ` Andy Shevchenko
2016-01-23 18:03 ` James Bottomley
2016-01-25 8:31 ` Andy Shevchenko
2016-01-25 15:25 ` James Bottomley
2016-01-23 18:12 ` James Bottomley
2016-01-23 20:29 ` One Thousand Gnomes
2016-01-23 20:43 ` H. Peter Anvin
2016-01-25 18:02 ` Elliott, Robert (Persistent Memory)
2016-01-25 18:56 ` James Bottomley
2016-01-25 19:28 ` Andy Shevchenko
2016-01-25 19:45 ` James Bottomley
2016-01-25 20:01 ` Andy Shevchenko
2016-01-25 20:18 ` James Bottomley
2016-01-25 20:37 ` Elliott, Robert (Persistent Memory)
2016-01-26 11:50 ` Matt Fleming
2016-01-26 11:59 ` Andy Shevchenko [this message]
2016-01-28 9:29 ` Matt Fleming
2016-01-28 11:15 ` Andy Shevchenko
2016-01-25 20:44 ` James Bottomley
2016-01-23 14:55 ` [PATCH v3 4/4] x86/efi: Use proper units in efi_find_mirror() Andy Shevchenko
2016-01-23 16:34 ` [PATCH v3 0/4] x86/efi: use binary units when printing James Bottomley
2016-01-23 17:20 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453809566.2521.239.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=andy.shevchenko@gmail.com \
--cc=elliott@hpe.com \
--cc=hpa@zytor.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=matt@codeblueprint.co.uk \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).