Re: [PATCH] regulator: core: Clear constraints pointer after free on error path

Mark Brown
2016-01-26T15:35:05Z

[-- Attachment #1: Type: text/plain, Size: 494 bytes --]

On Tue, Jan 26, 2016 at 03:14:16PM +0000, Charles Keepax wrote:

> As we now free the constraints in regulator_dev_release we will still
> call free on the constraints pointer even if we went down an error path
> in regulator_register, as such we need to clear to the pointer to ensure
> the kfree in regulator_dev_release is a no-op.

No, this is just making things worse - if we're doing the free in the
release we should be doing the free in the release not sometimes maybey
in the release.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]