From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946107AbcA1RSH (ORCPT ); Thu, 28 Jan 2016 12:18:07 -0500 Received: from mail-lf0-f66.google.com ([209.85.215.66]:36402 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161382AbcA1RR5 (ORCPT ); Thu, 28 Jan 2016 12:17:57 -0500 From: Michal Hocko To: Andrew Morton Cc: Cristopher Lameter , Mike Galbraith , , LKML , Michal Hocko Subject: [PATCH 2/2] vmstat: make vmstat_update deferrable Date: Thu, 28 Jan 2016 18:17:46 +0100 Message-Id: <1454001466-27398-3-git-send-email-mhocko@kernel.org> X-Mailer: git-send-email 2.7.0.rc3 In-Reply-To: <1454001466-27398-1-git-send-email-mhocko@kernel.org> References: <1454001466-27398-1-git-send-email-mhocko@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Michal Hocko 0eb77e988032 ("vmstat: make vmstat_updater deferrable again and shut down on idle") made vmstat_shepherd deferrable. vmstat_update itself is still useing standard timer which might interrupt idle task. This is possible because "mm, vmstat: make quiet_vmstat lighter" removed cancel_delayed_work from the quiet_vmstat. Change vmstat_work to use DEFERRABLE_WORK to prevent from pointless wakeups from the idle context. Acked-by: Christoph Lameter Signed-off-by: Michal Hocko --- mm/vmstat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/vmstat.c b/mm/vmstat.c index eb30bf45bd55..69537d2be6f6 100644 --- a/mm/vmstat.c +++ b/mm/vmstat.c @@ -1512,7 +1512,7 @@ static void __init start_shepherd_timer(void) int cpu; for_each_possible_cpu(cpu) - INIT_DELAYED_WORK(per_cpu_ptr(&vmstat_work, cpu), + INIT_DEFERRABLE_WORK(per_cpu_ptr(&vmstat_work, cpu), vmstat_update); if (!alloc_cpumask_var(&cpu_stat_off, GFP_KERNEL)) -- 2.7.0.rc3