From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752893AbcA2DQE (ORCPT ); Thu, 28 Jan 2016 22:16:04 -0500 Received: from ozlabs.org ([103.22.144.67]:37447 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751403AbcA2DQA (ORCPT ); Thu, 28 Jan 2016 22:16:00 -0500 Message-ID: <1454037358.30708.1.camel@ellerman.id.au> Subject: Re: [PATCH 3/3] param: convert some "on"/"off" users to strtobool From: Michael Ellerman To: Kees Cook , Andrew Morton Cc: x86@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, Joe Perches , Rasmus Villemoes , Daniel Borkmann , Amitkumar Karwar , Nishant Sarmukadam , Kalle Valo , Steve French , Heiko Carstens , Martin Schwidefsky , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 29 Jan 2016 14:15:58 +1100 In-Reply-To: <1453990627-19164-4-git-send-email-keescook@chromium.org> References: <1453990627-19164-1-git-send-email-keescook@chromium.org> <1453990627-19164-4-git-send-email-keescook@chromium.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5-1ubuntu3.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-01-28 at 06:17 -0800, Kees Cook wrote: > This changes several users of manual "on"/"off" parsing to use strtobool. You should probably point out that it's a slight behaviour change for some users. ie. parameters that previously *only* worked with "on"/"off", can now also take 0/1/y/n etc. But I don't think that's a show stopper. > Signed-off-by: Kees Cook > Cc: x86@kernel.org > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-s390@vger.kernel.org > --- > arch/powerpc/kernel/rtasd.c | 10 +++------- > arch/powerpc/platforms/pseries/hotplug-cpu.c | 11 +++-------- Acked-by: Michael Ellerman (powerpc) cheers