From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755940AbcA2MmA (ORCPT ); Fri, 29 Jan 2016 07:42:00 -0500 Received: from mga04.intel.com ([192.55.52.120]:3029 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755290AbcA2Ml6 (ORCPT ); Fri, 29 Jan 2016 07:41:58 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,364,1449561600"; d="scan'208";a="643470350" Message-ID: <1454071220.2521.311.camel@linux.intel.com> Subject: Re: [PATCH V2 4/4] serial: 8250_pci: Remove Fintek F81504/508/512 UART driver From: Andy Shevchenko To: Peter Hung , linus.walleij@linaro.org, gnurou@gmail.com, gregkh@linuxfoundation.org, paul.gortmaker@windriver.com, lee.jones@linaro.org, jslaby@suse.com, peter_hong@fintek.com.tw Cc: heikki.krogerus@linux.intel.com, peter@hurleysoftware.com, soeren.grunewald@desy.de, udknight@gmail.com, adam.lee@canonical.com, arnd@arndb.de, manabian@gmail.com, scottwood@freescale.com, yamada.masahiro@socionext.com, paul.burton@imgtec.com, mans@mansr.com, matthias.bgg@gmail.com, ralf@linux-mips.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-serial@vger.kernel.org, tom_tsai@fintek.com.tw, Peter Hung Date: Fri, 29 Jan 2016 14:40:20 +0200 In-Reply-To: <56AB20B1.9030609@gmail.com> References: <1453972838-30268-1-git-send-email-hpeter+linux_kernel@gmail.com> <1453972838-30268-5-git-send-email-hpeter+linux_kernel@gmail.com> <1453982657.2521.287.camel@linux.intel.com> <56AB20B1.9030609@gmail.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2016-01-29 at 16:20 +0800, Peter Hung wrote: > Hi Andy, > > Andy Shevchenko 於 2016/1/28 下午 08:04 寫道: > > On Thu, 2016-01-28 at 17:20 +0800, Peter Hung wrote: > > > - /* Fintek PCI serial cards */ > > > - { PCI_DEVICE(0x1c29, 0x1104), .driver_data = > > > pbn_fintek_4 }, > > > - { PCI_DEVICE(0x1c29, 0x1108), .driver_data = > > > pbn_fintek_8 }, > > > - { PCI_DEVICE(0x1c29, 0x1112), .driver_data = > > > pbn_fintek_12 > > > }, > > > > Shouldn't you blacklist them in 8250_pci? > > > > You are referring to add blacklist instead of remove F81504/508/512 > code? No. > or add blacklist and remove code? This one. Check what lspci tells you about your device. I'm pretty sure that it has Serial Class, which would trigger enumeration in 8250_pci.c if it comes first. -- Andy Shevchenko Intel Finland Oy