From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932874AbcA2Set (ORCPT ); Fri, 29 Jan 2016 13:34:49 -0500 Received: from mga09.intel.com ([134.134.136.24]:29974 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752191AbcA2Seq (ORCPT ); Fri, 29 Jan 2016 13:34:46 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,365,1449561600"; d="scan'208";a="904017919" Message-ID: <1454092514.32507.3.camel@linux.intel.com> Subject: Re: [PATCH 0/3] 8250: Split Fintek PCIE to UART to independent file From: Andy Shevchenko To: Sudip Mukherjee , Andy Shevchenko Cc: Peter Hung , Rob Groner , One Thousand Gnomes , Paul Gortmaker , Greg Kroah-Hartman , Jiri Slaby , "Krogerus, Heikki" , Peter Hurley , soeren.grunewald@desy.de, Wang YanQing , adam.lee@canonical.com, Arnd Bergmann , Masahiro Yamada , =?ISO-8859-1?Q?M=E5ns_Rullg=E5rd?= , scottwood@freescale.com, Paul Burton , Matthias Brugger , Joachim Eastwood , Peter Ujfalusi , "linux-kernel@vger.kernel.org" , "linux-serial@vger.kernel.org" , Peter H , Peter Hung Date: Fri, 29 Jan 2016 20:35:14 +0200 In-Reply-To: <20160129173808.GB18826@sudip-laptop> References: <1453171266-15874-1-git-send-email-hpeter+linux_kernel@gmail.com> <20160119035649.GA1696@windriver.com> <569DF7C3.5050306@gmail.com> <20160119123327.3b519062@lxorguk.ukuu.org.uk> <1453209684.2521.115.camel@linux.intel.com> <569EF810.1000304@gmail.com> <20160120062214.GB3747@sudip-pc> <569F4444.3040104@gmail.com> <20160122105350.GA7023@sudip-pc> <20160129173808.GB18826@sudip-laptop> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2016-01-29 at 23:08 +0530, Sudip Mukherjee wrote: > On Fri, Jan 22, 2016 at 03:44:16PM +0200, Andy Shevchenko wrote: > > On Fri, Jan 22, 2016 at 12:53 PM, Sudip Mukherjee > > wrote: > > > On Wed, Jan 20, 2016 at 04:24:36PM +0800, Peter Hung wrote: > > > > Hi Sudip, > > > > > > > > Sudip Mukherjee 於 2016/1/20 下午 02:22 寫道: > > > > > On Wed, Jan 20, 2016 at 10:59:28AM +0800, Peter Hung wrote: > > > > > > > > > But my personal opinion, if we move out the serial port > > > > > related code > > > > > into a new driver (a new Kconfig symbol) userspace of many > > > > > system will > > > > > break if this new symbol is not enabled by the distributions. > > > > > But in the > > > > > way I have done the new symbol needs to be enabled only if > > > > > the user > > > > > wants to use the GPIO capability. If that is not enabled GPIO > > > > > cannot be > > > > > used but it will never break the serial port related code for > > > > > them. > > > > > I think we should give a thought to that before splitting out > > > > > the codes > > > > > from 8250_pci. > > > > > > > > I agree with your opinion. I'm trying to implement GPIO with 2 > > > > ways, > > > > One is like yours, add platform_device with in 8250_pci.c and > > > > implement > > > > GPIOLIB platform driver with in 'driver/gpio", and the other is > > > > trying > > > > split out from 8250_pci.c to MFD. > > > > > > > > In my personal opinion, the first method is less impact with > > > > compatible > > > > old system. > > > > > > Looks like no one else is in support of our opinion. Fair enough, > > > I will > > > split out the related code from 8250_pci and create the MFD > > > driver this > > > weekend for my hardware. > > > > Yeah, MFD looks preferable. > > > > Btw, don't forget to backlist your devices in 8250_pci since they > > quite possible provide a PCI class which is used by 8250_pci driver > > for default enumeration. > > One doubt. If I have understood correctly the main reason you have > asked > me to split the code out of 8250_pci so that the size reduces. But > pci_xr17v35x_setup() is also used by another card which has > PCI_VENDOR_ID_COMMTECH. So even if I create a separate file for exar > cards, > almost identical function will still remain in 8250_pci. For me looks like re-branded Exar chip (Exar is a real chip vendor, right?). Even names fall in different pattern. Also,         {       PCI_VENDOR_ID_COMMTECH, PCI_DEVICE_ID_COMMTECH_4222PCIE,                 PCI_ANY_ID, PCI_ANY_ID,                 0,                 0, pbn_exar_XR17V352 }, ^^^^! Move those IDs to your driver as well. -- Andy Shevchenko Intel Finland Oy