From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933007AbcA3RZl (ORCPT ); Sat, 30 Jan 2016 12:25:41 -0500 Received: from smtprelay0189.hostedemail.com ([216.40.44.189]:43573 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932215AbcA3RZj (ORCPT ); Sat, 30 Jan 2016 12:25:39 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3870:3871:3872:3873:3874:4321:5007:6261:7875:7903:8957:10004:10400:10848:11232:11658:11914:12043:12517:12519:12740:13069:13161:13229:13311:13357:13894:14659:21067:21080:30012:30054:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: talk49_6b3e1fb61452c X-Filterd-Recvd-Size: 2277 Message-ID: <1454174735.7329.20.camel@perches.com> Subject: Re: [PATCH 3/4] netfilter: ipv4: use preferred kernel types From: Joe Perches To: Lucas Tanure , Patrick McHardy Cc: Pablo Neira Ayuso , Jozsef Kadlecsik , "David S . Miller" , Alexey Kuznetsov , coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Sat, 30 Jan 2016 09:25:35 -0800 In-Reply-To: References: <1454159878-20706-1-git-send-email-tanure@linux.com> <1454159878-20706-3-git-send-email-tanure@linux.com> <20160130134550.GA5613@macbook.localdomain> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.3-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2016-01-30 at 12:05 -0200, Lucas Tanure wrote: > On Sat, Jan 30, 2016 at 11:45 AM, Patrick McHardy wrote: > > On 30.01, Lucas Tanure wrote: > > > As suggested by checkpatch.pl: > > > CHECK: Prefer kernel type 'uX' over 'uintX_t' > > > > You might have noticed we have literally hundreds of them spread over 100 > > files in the netfilter code. We'll gradually change them when the code is > > touched anyways. > > > > >  net/ipv4/netfilter/ip_tables.c | 5 ++--- > > >  1 file changed, 2 insertions(+), 3 deletions(-) > > Yes, I checked that. But would be better to change that now? > Because: > - could take years to anyone to touch the code, as the code already > works very well > - be more standardized could facilitate reading the code > - It's a good way to encourage new people to contribute to the code The last one bullet point is what staging is for. It might be better to do them all at once: $ git grep --name-only "\bu_int" net/netfilter/ | \   xargs perl -p -i -e 's/\bu_int(\d+)_t\b/u\1/g'