From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932920AbcA3RhV (ORCPT ); Sat, 30 Jan 2016 12:37:21 -0500 Received: from smtprelay0158.hostedemail.com ([216.40.44.158]:47498 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932228AbcA3RhT (ORCPT ); Sat, 30 Jan 2016 12:37:19 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 30,2,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::,RULES_HIT:41:355:379:541:599:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3165:3353:3622:3865:3866:3867:3868:3870:3872:3873:3874:4250:4321:5007:6119:6261:6691:7903:10004:10400:10848:11026:11232:11473:11658:11783:11914:12043:12109:12114:12296:12438:12517:12519:12740:13069:13311:13357:13523:13524:13894:14659:21080:21326:30012:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: wax77_3f8d1eb703f44 X-Filterd-Recvd-Size: 2483 Message-ID: <1454175435.7329.22.camel@perches.com> Subject: Re: Build failure: -Wno-unused-const-variable DNE on old GCC From: Joe Perches To: "Maciej W. Rozycki" , Brian Norris Cc: Michal Marek , Michael Ellerman , Anton Blanchard , Ian Munsie , Michael Neuling , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Olof Johansson Date: Sat, 30 Jan 2016 09:37:15 -0800 In-Reply-To: References: <20160107185406.GA65420@google.com> <1452195444.4028.21.camel@perches.com> <568EC026.2020207@suse.com> <1452196651.4028.31.camel@perches.com> <20160107201826.GA120952@google.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.3-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2016-01-30 at 14:20 +0000, Maciej W. Rozycki wrote: > On Thu, 7 Jan 2016, Brian Norris wrote: > > > > Perhaps most uses of -Werror without some CONFIG_ guard > > > should be removed or replaced by some other mechanism. > > > > +1000. I'd personally like to see all one-off uses of -Werror removed. > > > > > $ git grep -E "=\s*\-Werror" | grep -v CONFIG > > > [...] > > > arch/alpha/lib/Makefile:ccflags-y := -Werror > > > arch/alpha/mm/Makefile:ccflags-y := -Werror > > > arch/alpha/oprofile/Makefile:ccflags-y := -Werror -Wno-sign-compare > > > arch/metag/oprofile/Makefile:ccflags-y += -Werror > > > arch/mips/Kbuild:subdir-ccflags-y := -Werror > > > > ^^ I always patch this one out when build-testing MIPS, since I like to > > turn up warning levels (e.g., W=1), but not kill the build entirely. > >  The MIPS port switched on -Werror years ago, because people submitted  > awful code and couldn't be bothered unless the build crashed.  You're  > welcome to patch your own tree, however I maintain it was a very good  > decision, and TBH I think -Werror should be on globally. That'd be easy to do with some CONFIG_COMPILER_ERROR type rather than in specific directory Makefiles