From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932913AbcBAORh (ORCPT ); Mon, 1 Feb 2016 09:17:37 -0500 Received: from mga11.intel.com ([192.55.52.93]:57939 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932418AbcBAORU (ORCPT ); Mon, 1 Feb 2016 09:17:20 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,380,1449561600"; d="scan'208";a="902995668" Message-ID: <1454336237.32507.17.camel@linux.intel.com> Subject: Re: [PATCH v1 1/1] PM: Avoid false-positive warnings in dev_pm_domain_set() From: Andy Shevchenko To: "Rafael J. Wysocki" , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: "Rafael J. Wysocki" Date: Mon, 01 Feb 2016 16:17:17 +0200 In-Reply-To: <1454335978-21467-1-git-send-email-andriy.shevchenko@linux.intel.com> References: <1454335978-21467-1-git-send-email-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2016-02-01 at 16:12 +0200, Andy Shevchenko wrote: > From: "Rafael J. Wysocki" > > There is a WARN_ON() in dev_pm_domain_set() that triggers on attempts > to set the pm_domain pointer for devices with a driver bound. > > However, that WARN_ON() triggers on attempts to clear the pointer > too and the test it uses is based on checking the device's > p->knode_driver pointer which still is set when the device bus > type's/driver's ->remove callback has been executed.  This > leads to false-positive warnings when bus type code calls > dev_pm_domain_set() to clear the pm_domain pointer after > invoking the driver's ->remove() callback. > > To avoid those false-positives, make dev_pm_domain_set() check > if the pointer passed to it is NULL and skip the warning in > that case. > > Fixes: 989561de9b51 (PM / Domains: add setter for dev.pm_domain) > Signed-off-by: Rafael J. Wysocki > Signed-off-by: Andy Shevchenko Oops, it is a wrong one, should be previous. Btw, this one has been tested and went fine! -- Andy Shevchenko Intel Finland Oy