From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933093AbcBAOnd (ORCPT ); Mon, 1 Feb 2016 09:43:33 -0500 Received: from mga04.intel.com ([192.55.52.120]:46153 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932645AbcBAOnb (ORCPT ); Mon, 1 Feb 2016 09:43:31 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,380,1449561600"; d="scan'208";a="903011267" Message-ID: <1454337845.32507.20.camel@linux.intel.com> Subject: Re: [PATCH] i2c: designware: balance clk enable/disable on removal From: Andy Shevchenko To: Jarkko Nikula , Alexey Khoroshilov , Mika Westerberg Cc: Wolfram Sang , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org Date: Mon, 01 Feb 2016 16:44:05 +0200 In-Reply-To: <56AF69D3.4070300@linux.intel.com> References: <1454106696-5867-1-git-send-email-khoroshilov@ispras.ru> <56AF69D3.4070300@linux.intel.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2016-02-01 at 16:21 +0200, Jarkko Nikula wrote: > On 01/30/2016 12:31 AM, Alexey Khoroshilov wrote: > > It seems clk_disable_unprepare() is missed in dw_i2c_plat_remove(), > > so the patch adds it. > > > > Found by Linux Driver Verification project (linuxtesting.org). > > > > Signed-off-by: Alexey Khoroshilov > > --- > >   drivers/i2c/busses/i2c-designware-platdrv.c | 1 + > >   1 file changed, 1 insertion(+) > > > > diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c > > b/drivers/i2c/busses/i2c-designware-platdrv.c > > index 438f1b4964c0..8f19b7b81fe0 100644 > > --- a/drivers/i2c/busses/i2c-designware-platdrv.c > > +++ b/drivers/i2c/busses/i2c-designware-platdrv.c > > @@ -267,6 +267,7 @@ static int dw_i2c_plat_remove(struct > > platform_device *pdev) > >    i2c_del_adapter(&dev->adapter); > > > >    i2c_dw_disable(dev); > > + i2c_dw_plat_prepare_clk(dev, false); > > > I tried this quickly and it appears more work is needed. When  > CONFIG_PM_SLEEP is set then autosuspending will do the unprepare and  > this patch causes double unprepare at remove. But when > CONFIG_PM_SLEEP  > is not set then indeed those clk calls are out of sync. Besides that I would suggest to check carefully error patch in the probe(), i.e. handling error from i2c_dw_probe(). There maybe similar issue is hidden. -- Andy Shevchenko Intel Finland Oy