From: Jeffrey Merkey <jeffmerkey@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: hpa@zytor.com, jeffmerkey@gmail.com, mingo@redhat.com,
tglx@linutronix.de, x86@kernel.org
Subject: [PATCH v5 1/3] Add BUG_XX() debugging options
Date: Mon, 1 Feb 2016 19:33:46 -0700 [thread overview]
Message-ID: <1454380428-31474-1-git-send-email-jeffmerkey@gmail.com> (raw)
This patch series adds config options which can be set during compile to
direct the compiler to output a breakpoint instruction anywhere a BUG()
macro has been placed in the kernel to trigger the system to
enter a debugger if a bug is detected by the system. Use of this
compile time option also allows conditional breakpoints to be set in the
kernel with these currently used macros.
This addition is extremely useful for debugging hard and soft lockups
real time and quickly from a console debugger, and other areas of the
kernel.
Signed-off-by: Jeffrey Merkey <jeffmerkey@gmail.com>
---
arch/x86/include/asm/bug.h | 17 ++++++++++++++++-
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/arch/x86/include/asm/bug.h b/arch/x86/include/asm/bug.h
index ba38ebb..df26c2b 100644
--- a/arch/x86/include/asm/bug.h
+++ b/arch/x86/include/asm/bug.h
@@ -11,6 +11,13 @@
# define __BUG_C0 "2:\t.long 1b - 2b, %c0 - 2b\n"
#endif
+#ifdef CONFIG_DEBUG_BUG
+#define BUG() \
+do { \
+ asm volatile("int3"); \
+ unreachable(); \
+} while (0)
+#else
#define BUG() \
do { \
asm volatile("1:\tud2\n" \
@@ -23,7 +30,14 @@ do { \
"i" (sizeof(struct bug_entry))); \
unreachable(); \
} while (0)
-
+#endif
+#else
+#ifdef CONFIG_DEBUG_BUG
+#define BUG() \
+do { \
+ asm volatile("int3"); \
+ unreachable(); \
+} while (0)
#else
#define BUG() \
do { \
@@ -31,6 +45,7 @@ do { \
unreachable(); \
} while (0)
#endif
+#endif
#include <asm-generic/bug.h>
--
1.8.3.1
next reply other threads:[~2016-02-02 2:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 2:33 Jeffrey Merkey [this message]
2016-02-02 2:33 ` [PATCH v5 2/3] Add BUG_XX() debugging options Kconfig.debug Jeffrey Merkey
2016-02-02 2:33 ` [PATCH v5 3/3] Add BUG_XX() debugging hard/soft lockup detection Jeffrey Merkey
2016-02-02 17:30 ` Don Zickus
2016-02-02 22:40 ` Jeffrey Merkey
2016-02-03 4:17 ` Jeffrey Merkey
2016-02-03 4:39 ` Jeffrey Merkey
2016-02-03 15:45 ` Don Zickus
2016-02-03 17:23 ` Jeffrey Merkey
2016-02-03 20:14 ` Don Zickus
2016-02-03 20:18 ` Jeffrey Merkey
2016-02-04 2:48 ` Jeffrey Merkey
2016-02-03 15:47 ` Don Zickus
2016-02-03 17:26 ` Jeffrey Merkey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454380428-31474-1-git-send-email-jeffmerkey@gmail.com \
--to=jeffmerkey@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox